This is an automated comment for commit 8420c3d with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

@yakov-olkhovskiy It is intended to work this way. You can change it, but it should be labeled as a backward incompatible change and we should add a compatibility setting.

@alexey-milovidov yes, I already somehow investigated this - the test which is failing seems to indicate that it was intended at least at some point, but I find it inconsistent - we have context itself, then query context, session context and global context within - I don't exactly understand what the difference then and the usage seems inconsistent - I want to discuss it with the team to decide how we want it...

Yes, I also checked... the reason I tell is because I remember how, and why I've added this table :)

So, when it was developed, the intent was to show the settings effective for this particular query from system.settings.
The motivation is - these are the most "deep" settings, that we can get. They include the most overrides possible, so it is like the most information that we can show.

Then I checked the docs, and it stated that it shows session-level settings, which is surprising. Maybe it was lost when the docs were written.

I don't mind changing this behavior, so your change is good for me.
But what is the problem with Analyzer?

In analyzer we calculate effective limit and offset as a query expression and put it into query tree, and remove from setting to prevent further interference:
https://github.com/ClickHouse/ClickHouse/blob/master/src/Analyzer/QueryTreeBuilder.cpp#L247-L249

Of course this problem can be addressed differently - instead removing from settings I can find further interference and prevent it... I think it's a better approach than changing meaning of system.settings. Will do this.

A test has failed.

Dear @yakov-olkhovskiy, this PR hasn't been updated for a while. Will you continue working on it? If not, please close it. Otherwise, ignore this message.