Skip to content

Add support for MySQL net_write_timeout and net_read_timeout settings#58835

Merged
alexey-milovidov merged 5 commits into
ClickHouse:masterfrom
slvrtrn:support-net-write-read-settings
Jan 16, 2024
Merged

Add support for MySQL net_write_timeout and net_read_timeout settings#58835
alexey-milovidov merged 5 commits into
ClickHouse:masterfrom
slvrtrn:support-net-write-read-settings

Conversation

@slvrtrn

@slvrtrn slvrtrn commented Jan 15, 2024

Copy link
Copy Markdown
Contributor

Resolves #58553

Allows to use the following settings via MySQL interface:

SET NET_WRITE_TIMEOUT = X;
SET NET_READ_TIMEOUT = Y;

net_write_timeout is translated into the native send_timeout ClickHouse setting and, similarly, net_read_timeout into receive_timeout. These statements work regardless of the input query being upper or lower case.

Additionally, fixed an issue where changing MySQL SQL_SELECT_LIMIT setting was possible only if the entire statement was in upper case.

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

MySQL interface gained support for net_write_timeout and net_read_timeout settings. net_write_timeout is translated into the native send_timeout ClickHouse setting and, similarly, net_read_timeout into receive_timeout. Fixed an issue where it was possible to set MySQL sql_select_limit setting only if the entire statement was in upper case.

@slvrtrn
slvrtrn requested a review from rschu1ze January 15, 2024 16:54
@slvrtrn slvrtrn added pr-improvement Pull request with some product improvements can be tested Allows running workflows for external contributors labels Jan 15, 2024
@robot-ch-test-poll1

robot-ch-test-poll1 commented Jan 15, 2024 •
edited by robot-ch-test-poll3
Loading

Copy link
Copy Markdown
Contributor

This is an automated comment for commit 204a291 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

alexey-milovidov
alexey-milovidov approved these changes Jan 15, 2024
View reviewed changes

@alexey-milovidov alexey-milovidov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

A bit rough but in line with the existing code in MySQLHandler.

@alexey-milovidov alexey-milovidov self-assigned this Jan 15, 2024
@alexey-milovidov

alexey-milovidov commented Jan 15, 2024

Copy link
Copy Markdown
Member

Possible better solution will be:

  • support all missing queries in ClickHouse's parser and interpreter (e.g., SHOW TABLE STATUS);
  • introduce case-insensitive settings;
  • introduce settings aliases;

@alexey-milovidov
alexey-milovidov merged commit 786f372 into ClickHouse:master Jan 16, 2024
@tavplubix

tavplubix commented Jan 16, 2024

Copy link
Copy Markdown
Member

It was merged without checking the CI status, and looks like it breaks 02967_mysql_settings_override. Sorry, I have to revert this

@tavplubix tavplubix mentioned this pull request Jan 16, 2024
Merged
@slvrtrn

slvrtrn commented Jan 16, 2024

Copy link
Copy Markdown
Contributor Author

@tavplubix, thanks for the heads up; I will double-check what's up with 02967_mysql_settings_override (it's actually a new one introduced in this PR).

@slvrtrn slvrtrn mentioned this pull request Jan 18, 2024
Merged
@slvrtrn slvrtrn mentioned this pull request Jan 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes
@rschu1ze rschu1ze Awaiting requested review from rschu1ze

Assignees

@alexey-milovidov alexey-milovidov

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MySQL compatibility: SET net_write_timeout

4 participants

@slvrtrn @robot-ch-test-poll1 @alexey-milovidov @tavplubix