Skip to content

Analyzer: Fix assertion in HashJoin with duplicate columns#58652

Merged
vdimir merged 3 commits intomasterfrom
vdimir/analyzer_hash_join_duplicate_columns
Jan 16, 2024
Merged

Analyzer: Fix assertion in HashJoin with duplicate columns#58652
vdimir merged 3 commits intomasterfrom
vdimir/analyzer_hash_join_duplicate_columns

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Jan 10, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 10, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Jan 10, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 61f2ab3 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@vdimir vdimir force-pushed the vdimir/analyzer_hash_join_duplicate_columns branch from 83007c5 to cb17762 Compare January 10, 2024 12:38
vdimir
vdimir commented Jan 10, 2024
View reviewed changes
src/Interpreters/HashJoin.cpp
/// Based on:
/// - map offsetInternal saved in used_flags for single disjuncts
/// - flags in BlockWithFlags for multiple disjuncts
template <bool multiple_disjuncts>
Copy link
Copy Markdown
Member Author

@vdimir vdimir Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This template seemed to be useless

Copy link
Copy Markdown
Member

@novikd novikd Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only possible difference -- performance. Better to check Performance Tests results.

@vdimir vdimir mentioned this pull request Jan 10, 2024
Merged
2 tasks
@vdimir vdimir added the analyzer Issues and pull-requests related to new analyzer label Jan 10, 2024
@novikd novikd self-assigned this Jan 10, 2024
novikd
novikd approved these changes Jan 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@novikd novikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Interpreters/HashJoin.cpp
/// Based on:
/// - map offsetInternal saved in used_flags for single disjuncts
/// - flags in BlockWithFlags for multiple disjuncts
template <bool multiple_disjuncts>
Copy link
Copy Markdown
Member

@novikd novikd Jan 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only possible difference -- performance. Better to check Performance Tests results.

@vdimir vdimir force-pushed the vdimir/analyzer_hash_join_duplicate_columns branch from bc40be9 to 61f2ab3 Compare January 15, 2024 11:37
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Jan 16, 2024

Stateless tests (debug) [5/5] — fail: 1, passed: 1191, skipped: 9 Details

01961_roaring_memory_tracking is slow with max_bytes_before_external_group_by = 1 #58863

Stateless tests (tsan, s3 storage) [5/5] — Tests are not finished, fail: 1, passed: 1026, skipped: 13 Details

#58437

@vdimir vdimir merged commit de3e701 into master Jan 16, 2024
@vdimir vdimir deleted the vdimir/analyzer_hash_join_duplicate_columns branch January 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novikd novikd novikd approved these changes

Assignees

@novikd novikd

Labels

analyzer Issues and pull-requests related to new analyzer pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vdimir @robot-ch-test-poll3 @novikd