Skip to content

Second attempt: Use CH Buffer for HTTP out stream, add metrics for interfaces#58475

Merged
yakov-olkhovskiy merged 10 commits intomasterfrom
revert-58450-revert-56064-feature-server-iface-metrics
Jan 11, 2024
Merged

Second attempt: Use CH Buffer for HTTP out stream, add metrics for interfaces#58475
yakov-olkhovskiy merged 10 commits intomasterfrom
revert-58450-revert-56064-feature-server-iface-metrics

Conversation

@yakov-olkhovskiy
Copy link
Copy Markdown
Member

@yakov-olkhovskiy yakov-olkhovskiy commented Jan 3, 2024

Reverts #58450

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 3, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jan 3, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 4fc11e1 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure

@yakov-olkhovskiy yakov-olkhovskiy marked this pull request as ready for review January 5, 2024 15:46
@yakov-olkhovskiy
Copy link
Copy Markdown
Member Author

yakov-olkhovskiy commented Jan 9, 2024

@CheSema could you please review it again - I fixed two issues here

@CheSema
Copy link
Copy Markdown
Member

CheSema commented Jan 9, 2024

@CheSema could you please review it again - I fixed two issues here

Do you know how can I see the diff with prev version?

@yakov-olkhovskiy
Copy link
Copy Markdown
Member Author

yakov-olkhovskiy commented Jan 9, 2024 •
edited
Loading

In general you would need to take diff between beginning commit of this branch and head of this branch. But it will be messy since there are couple merges with master in this branch. But changes are not that big - you can take a look just at individual commits above -
fix for leaking exception:
84dd4a7
fix for flaky "connection reset by peer" (I'll say couple words on this one on the todays meeting):
feab812
and another change is for better testing - adding some logging:
0964bf3

@yakov-olkhovskiy yakov-olkhovskiy merged commit 84809b3 into master Jan 11, 2024
@yakov-olkhovskiy yakov-olkhovskiy deleted the revert-58450-revert-56064-feature-server-iface-metrics branch January 11, 2024 17:07
@yakov-olkhovskiy yakov-olkhovskiy mentioned this pull request Jan 16, 2024
Merged
@azat azat mentioned this pull request Jan 19, 2024
Merged
@Avogar Avogar mentioned this pull request Jan 23, 2024
Closed
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CheSema CheSema CheSema approved these changes

Assignees

@CheSema CheSema

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yakov-olkhovskiy @robot-ch-test-poll1 @CheSema @robot-clickhouse