Skip to content

Followup for #56996#58289

Merged
alexey-milovidov merged 2 commits intomasterfrom
vdimir/followup-56996
Aug 15, 2024
Merged

Followup for #56996#58289
alexey-milovidov merged 2 commits intomasterfrom
vdimir/followup-56996

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Dec 28, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 28, 2023
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Dec 28, 2023 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit 4fad666 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vdimir vdimir mentioned this pull request Dec 28, 2023
Merged
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jun 25, 2024

Dear @devcrafter, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jul 13, 2024

@vdimir, could you please fix a conflict?

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the submodule changed At least one submodule changed in this PR. label Jul 15, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 removed the submodule changed At least one submodule changed in this PR. label Jul 15, 2024
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Aug 12, 2024

@vdimir, would you mind finishing this PR?

@vdimir vdimir force-pushed the vdimir/followup-56996 branch from 0d2281b to 3c034ef Compare August 12, 2024 08:22
@vdimir vdimir force-pushed the vdimir/followup-56996 branch from 3c034ef to 5c54c70 Compare August 12, 2024 08:26
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Aug 12, 2024 •
edited
Loading

Stateless tests (tsan) [4/4] — Server died, fail: 0, passed: 895, skipped: 16 Details

Pretty interesting failure

clickhouse-test reported ProcessLookupError 
2024-08-12 17:46:45 02907_http_exception_json_bug:                                          [ OK ] 29.26 sec.
2024-08-12 17:49:00 2173
2024-08-12 17:51:29 03173_row_binary_and_native_with_binary_encoded_types:                  [ OK ] 104.36 sec.
2024-08-12 17:51:29 Process Process-3:
2024-08-12 17:51:29 Traceback (most recent call last):
2024-08-12 17:51:29   File "/usr/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
2024-08-12 17:51:29     self.run()
2024-08-12 17:51:29   File "/usr/lib/python3.10/multiprocessing/process.py", line 108, in run
2024-08-12 17:51:29     self._target(*self._args, **self._kwargs)
2024-08-12 17:51:29   File "/usr/bin/clickhouse-test", line 2527, in run_tests_process
2024-08-12 17:51:29     return run_tests_array(*args, **kwargs)
2024-08-12 17:51:29   File "/usr/bin/clickhouse-test", line 2245, in run_tests_array
2024-08-12 17:51:29     stop_tests()
2024-08-12 17:51:29   File "/usr/bin/clickhouse-test", line 442, in stop_tests
2024-08-12 17:51:29     cleanup_child_processes(os.getpid())
2024-08-12 17:51:29   File "/usr/bin/clickhouse-test", line 430, in cleanup_child_processes
2024-08-12 17:51:29     child_pgid = os.getpgid(child)
2024-08-12 17:51:29 ProcessLookupError: [Errno 3] No such process
2024-08-12 17:51:29 Child processes of 2223:
2024-08-12 17:51:29 33316 /bin/sh -c pgrep --parent 2223 -a
2024-08-12 17:51:29 01852_cast_operator_bad_cases:                                          [ OK ] 134.39 sec.
2024-08-12 17:51:29 Process Process-10:
2024-08-12 17:51:29 Traceback (most recent call last):
2024-08-12 17:51:29   File "/usr/lib/python3.10/multiprocessing/process.py", line 314, in _bootstrap
2024-08-12 17:51:29     self.run()
2024-08-12 17:51:29   File "/usr/lib/python3.10/multiprocessing/process.py", line 108, in run
2024-08-12 17:51:29     self._target(*self._args, **self._kwargs)
2024-08-12 17:51:29   File "/usr/bin/clickhouse-test", line 2527, in run_tests_process
2024-08-12 17:51:29     return run_tests_array(*args, **kwargs)
2024-08-12 17:51:29   File "/usr/bin/clickhouse-test", line 2245, in run_tests_array
2024-08-12 17:51:29     stop_tests()
2024-08-12 17:51:29   File "/usr/bin/clickhouse-test", line 442, in stop_tests
2024-08-12 17:51:29     cleanup_child_processes(os.getpid())
2024-08-12 17:51:29   File "/usr/bin/clickhouse-test", line 430, in cleanup_child_processes
2024-08-12 17:51:29     child_pgid = os.getpgid(child)
2024-08-12 17:51:29 ProcessLookupError: [Errno 3] No such process
2024-08-12 17:51:29 Child processes of 2251:
2024-08-12 17:51:29 33323 /bin/sh -c pgrep --parent 2251 -a

However server was running and several minutes after that got termination signal:

2024.08.12 17:59:55.297800 [ 1505 ] {} <Debug> system.zookeeper_log (e179afda-05ed-4bd4-9c4e-ed19f5bf12f9): Removing 6 parts from filesystem (serially): Parts: [202408_87_116_6, 202408_117_117_0, 202408_118_118_0,202408_119_119_0, 202408_120_120_0, 202408_121_121_0]
2024.08.12 17:59:55.304271 [ 1505 ] {} <Debug> system.zookeeper_log (e179afda-05ed-4bd4-9c4e-ed19f5bf12f9): Removing 6 parts from memory: Parts: [202408_87_116_6, 202408_117_117_0, 202408_118_118_0, 202408_119_119_0,202408_120_120_0, 202408_121_121_0]
2024.08.12 17:59:55.461758 [ 854 ] {} <Trace> BaseDaemon: Received signal 15
2024.08.12 17:59:55.461935 [ 854 ] {} <Information> Application: Received termination signal (Terminated)
2024.08.12 17:59:55.462084 [ 851 ] {} <Debug> Application: Received termination signal.
2024.08.12 17:59:55.462544 [ 851 ] {} <Debug> Application: Waiting for current connections to close.
2024.08.12 17:59:56.000218 [ 1565 ] {} <Trace> AsynchronousMetrics: MemoryTracking: was 4.85 GiB, peak 8.39 GiB, free memory in arenas 0.00 B, will set to 4.82 GiB (RSS), difference: -33.46 MiB

UPD #67737 (comment)

@alexey-milovidov alexey-milovidov added this pull request to the merge queue Aug 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 15, 2024
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Aug 15, 2024
Merged via the queue into master with commit e9d6b2a Aug 15, 2024
@alexey-milovidov alexey-milovidov deleted the vdimir/followup-56996 branch August 15, 2024 01:37
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devcrafter devcrafter devcrafter approved these changes

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vdimir @robot-clickhouse-ci-2 @alexey-milovidov @devcrafter @robot-ch-test-poll1 @robot-ch-test-poll2 @robot-clickhouse-ci-1