Skip to content

Everything should work on AArch64#58061

Closed
alexey-milovidov wants to merge 15 commits intomasterfrom
everything-should-work-on-aarch64
Closed

Everything should work on AArch64#58061
alexey-milovidov wants to merge 15 commits intomasterfrom
everything-should-work-on-aarch64

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 20, 2023
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Dec 20, 2023

This is an automated comment for commit 511ef1e with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncIf it fails, ask a maintainer for help❌ failure
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckChecks correctness of the PR's body✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@robot-clickhouse robot-clickhouse added the submodule changed At least one submodule changed in this PR. label Mar 4, 2024
@alexey-milovidov
Copy link
Copy Markdown
Member Author

Step 1: #60807

alexey-milovidov added a commit that referenced this pull request May 8, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 8, 2024
…arch64-part-2

Almost everything should work on AArch64 (Part of #58061)
@rschu1ze
Copy link
Copy Markdown
Member

My other PR #63675 removes Annoy (in favor of USearch). All exclusions no-cpu-aarch64 in 02354_vector_search*.sql are removed by the other PR.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented May 17, 2024

I doubt about the complete removal of Annoy, because at least one big, nice company is successfully using it...
But Annoy is a simple algorithm - we can rewrite the library.

@rschu1ze
Copy link
Copy Markdown
Member

If you look at vector search extensions in other relational and vector DBs, you find HNSW in almost all systems, and Annoy only rarely implemented. From what I read, Annoy doesn't work great with high dimensionality. This was the main reason to remove it.

Actually, #63675 provides a generic "vector similarity" index and the algorithms is specified like this:

CREATE TABLE tab (id Int32, vec Array(Float32), INDEX vec_idx(vec) TYPE vector_similarity('hnsw', 'L2Distance'));

So if we want, we can add it back, perhaps implemented from scratch.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

Ah, ok. Let's remove it for now. Possibly add it back later.
At least the data could be re-indexed.

@al13n321
Copy link
Copy Markdown
Member

#64563 for 02892_orc_filter_pushdown.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

Only Annoy and Intel QPL are not going to be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants