Use mimalloc instead of lfallocator#5775
Merged
alexey-milovidov merged 5 commits intomasterfrom Jun 28, 2019
Merged
Conversation
danlark1
added
can be tested
pr-bugfix
| struct MiAllocator | ||
| { | ||
|
|
||
| static void * alloc(size_t size, size_t alignment = 0) |
Member
There was a problem hiding this comment.
If you move to .cpp, you don't have to make any changes to
dbms/src/Interpreters/Compiler.cpp
Contributor
Author
There was a problem hiding this comment.
But we lose the dead code elimination property if alignment is zero which is rather common case
added 2 commits
June 28, 2019 00:43
stavrolia
pushed a commit
that referenced
this pull request
Jul 3, 2019
Use mimalloc instead of lfallocator (cherry picked from commit 6e77fc4)
abyss7
pushed a commit
that referenced
this pull request
Jul 11, 2019
Use mimalloc instead of lfallocator (cherry picked from commit 6e77fc4)
Member
|
This was not a bugfix but bug-introduce. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
For changelog. Remove if this is non-significant change.
Category (leave one):
Short description (up to few sentences):
Let's use mimalloc instead of lfallocator not to provide arenas for each allocation