Skip to content

Trivial improvement on array join #57183

Merged
Algunenano merged 2 commits intoClickHouse:masterfrom
bigo-sg:opt_array_join
Nov 28, 2023
Merged

Trivial improvement on array join #57183
Algunenano merged 2 commits intoClickHouse:masterfrom
bigo-sg:opt_array_join

Conversation

@taiyang-li
Copy link
Copy Markdown
Contributor

@taiyang-li taiyang-li commented Nov 24, 2023

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Trivial improvement on array join, reuse some intermediate results.

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-performance Pull request with some performance improvements label Nov 24, 2023
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Nov 24, 2023 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit f33f231 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Nov 24, 2023

Tests are broken

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Nov 26, 2023

Need to fix or close.

@Algunenano Algunenano mentioned this pull request Nov 27, 2023
Closed
Algunenano
Algunenano reviewed Nov 27, 2023
View reviewed changes
src/Interpreters/ArrayJoinAction.cpp
current.column = current.column->cut(current_row, next_row - current_row);

/// Reuse cut_any_col if possible to avoid unnecessary cut.
if (!is_unaligned && !is_left && current.name == *columns.begin())
Copy link
Copy Markdown
Member

@Algunenano Algunenano Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is far from trivial as the PR suggested. I'm not sure if comparing by name won't come back to bite us. In any case, this is not a "trivial" improvement. Considering cut_any_col might have been transformed by convertToFullColumnIfConst(), is it still correct?

Also found some issue while testing if this would work (but it breaks in master without the changes) -> #57243

Copy link
Copy Markdown
Contributor Author

@taiyang-li taiyang-li Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is still correct.

Copy link
Copy Markdown
Contributor Author

@taiyang-li taiyang-li Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as any_array is transformed from the first array join column, comparision by name is right.
If array join column is huge, then current improvement could avoid cutting twice from array join column

Copy link
Copy Markdown
Contributor Author

@taiyang-li taiyang-li Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Algunenano I'll fix the issue you mentioned before.

@Algunenano Algunenano merged commit 335e7bf into ClickHouse:master Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

@alexey-milovidov alexey-milovidov

Labels

pr-performance Pull request with some performance improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@taiyang-li @robot-ch-test-poll4 @Algunenano @alexey-milovidov