Skip to content

gRPC: remove build dependency on systemd#56671

Merged
rschu1ze merged 3 commits intoClickHouse:masterfrom
Algunenano:revert_grpc
Nov 13, 2023
Merged

gRPC: remove build dependency on systemd#56671
rschu1ze merged 3 commits intoClickHouse:masterfrom
Algunenano:revert_grpc

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Nov 13, 2023 •
edited by rschu1ze
Loading

This reverts commit 213c7cf, reversing changes made to 9ed4774.

This fixes a glitch that gRPC, starting from v1.52 (here), builds against systemd.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Breaks the build if the system has systemd headers installed. The system headers should not affect the build at all to begin with.

#56543 (comment)

@Algunenano Algunenano requested a review from rschu1ze November 13, 2023 12:54
@robot-clickhouse robot-clickhouse added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Nov 13, 2023
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Nov 13, 2023 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit ed7bfef with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ error

@rschu1ze rschu1ze changed the title Revert "Merge pull request #56543 from rschu1ze/bump-grpc" gRPC: remove build dependency on systemd Nov 13, 2023
@rschu1ze rschu1ze mentioned this pull request Nov 13, 2023
Merged
Algunenano and others added 3 commits November 13, 2023 16:27
@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented Nov 13, 2023

Build failed for unrelated reasons (cloning other submodules). Rebased to merge. It's building ok locally

@rschu1ze rschu1ze mentioned this pull request Nov 13, 2023
Merged
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Nov 13, 2023 •
edited
Loading

Ok.

And the next step is #35630

@rschu1ze
Copy link
Copy Markdown
Member

rschu1ze commented Nov 13, 2023

And the next step is #35630

We should first upgrade to the latest grpc and protobuf (and we are getting closer step by step), otherwise this will be wasted work. They change something with the build in almost each release...

@rschu1ze rschu1ze merged commit 4483055 into ClickHouse:master Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

@rschu1ze rschu1ze rschu1ze approved these changes

Assignees

@Algunenano Algunenano

@rschu1ze rschu1ze

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Algunenano @robot-clickhouse @alexey-milovidov @rschu1ze