Bump gRPC to v1.55.4 and protobuf to v22.5 by rschu1ze · Pull Request #56664 · ClickHouse/ClickHouse

rschu1ze · 2023-11-13T10:37:34Z

(this PR will accumulate multiple version bumps, cf. #56059 (review) EDIT: No, it won't as v1.55.4 required some major changes)

Bumped gRPC to v1.55.4, this was only possible by also bumping protobuf to v22.5

Changelog category (leave one):

Not for changelog (changelog entry is not required)

robot-clickhouse-ci-1 · 2023-11-13T10:38:04Z

This is an automated comment for commit e8eb425 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

mkmkme · 2023-11-13T15:04:14Z

Is my understanding correct that those versions do not yet require updating proto file to use editions?

rschu1ze · 2023-11-13T16:00:51Z

Editions are introduced only with protobuf v25.

mkmkme · 2023-11-14T07:18:13Z

Editions are introduced only with protobuf v25.

Noted. Is there still a need for updating protobuf and gRPC to the latest and update the proto file (as discussed in Slack)?

rschu1ze · 2023-11-14T12:00:15Z

Noted. Is there still a need for updating protobuf and gRPC to the latest and update the proto file (as discussed in Slack)?

@mkmkme Eventually yes, but in a future PR. gRPC and protobuf are quite hairy and can only be upgraded in "lockstep" (I believe this was also your experience). I have been trying to upgrade both but it is a slow process. Even with this PR, both are behind their current upstream versions. "Editions" are introduced with the latest and greatest protobuf that (I speculate) can be introduced in two weeks at the earliest with the current pace. I can continue the upgrade process, and in case I have questions I may come back to you.

rschu1ze · 2023-11-14T19:15:47Z

@Algunenano I'd appreciate if you could take a look + possibly approve, thanks.

Algunenano

LGTM.

There is a cmake warning for grpc but I don't know if it was introduced in this PR or one of the prior ones:

-- Adding contrib module grpc (configuring with grpc-cmake)
CMake Warning (dev) at contrib/grpc/CMakeLists.txt:50 (option):
  Policy CMP0077 is not set: option() honors normal variables.  Run "cmake
  --help-policy CMP0077" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  For compatibility with older versions of CMake, option is clearing the
  normal variable 'gRPC_BUILD_CSHARP_EXT'.
This warning is for project developers.  Use -Wno-dev to suppress it.

rschu1ze · 2023-11-16T11:05:33Z

Thanks. The warning technically existed already before this PR but more likely it was introduced with one of my many earlier gRPC updates. I'll check if I can get rid of it.

* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20231117) * fix build due to ClickHouse/ClickHouse#56664 --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>

* Bump protobuf to v3.18.x (ref: ClickHouse/ClickHouse#50400) * Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#55963) * Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#50920) * Update contribe/orc (ref: ClickHouse/ClickHouse#53324) * Bump protobuf to v21.9 (ref: ClickHouse/ClickHouse#56014) * Removed unused code in google-protobuf-cmake/CMakeLists.txt (ref: ClickHouse/ClickHouse#56102) * Bump gRPC to v1.55.4 and protobuf to v22.5 (ref: ClickHouse/ClickHouse#56664) * Bump gRPC to v1.59 and protobuf to v24.4 (ref: ClickHouse/ClickHouse#56853) * enable functions in readonly mode (ref: ClickHouse/ClickHouse#42708) * Introduce more fields for in-source function documentation (ref: ClickHouse/ClickHouse#49300) * Add ability to convert timeplusd table structure to CapnProto/Protobuf format schema (ref: ClickHouse/ClickHouse#52278) * Well known protos (ref: ClickHouse/ClickHouse#56741) * Update protobuf to v25.1 (ref: ClickHouse/ClickHouse#58020) * fixed unit_tests_dbms build * Avoid ignoring errors of execute_process() (set COMMAND_ERROR_IS_FATAL=ANY) (ref: ClickHouse/ClickHouse#68267) * fixed reigsterFunction * fixed error after rebase

robot-clickhouse-ci-1 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Nov 13, 2023

This comment was marked as resolved.

Sign in to view

rschu1ze force-pushed the bump-grpc branch from 8871f82 to f95c90c Compare November 14, 2023 11:55

Bump gRPC to v1.55.4 and protobuf to v22.5

cf7f155

rschu1ze force-pushed the bump-grpc branch from f95c90c to cf7f155 Compare November 14, 2023 12:01

Try to fix new calamities with cross-compilation

e8eb425

rschu1ze marked this pull request as ready for review November 14, 2023 19:14

Algunenano self-assigned this Nov 14, 2023

Algunenano approved these changes Nov 16, 2023

View reviewed changes

rschu1ze merged commit 8fe093c into ClickHouse:master Nov 16, 2023

rschu1ze mentioned this pull request Nov 16, 2023

Bump gRPC to v1.59 and protobuf to v24.4 #56853

Merged

baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 17, 2023

fix build due to ClickHouse/ClickHouse#56664

bf68e3c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump gRPC to v1.55.4 and protobuf to v22.5#56664

Bump gRPC to v1.55.4 and protobuf to v22.5#56664
rschu1ze merged 2 commits intoClickHouse:masterfrom
rschu1ze:bump-grpc

rschu1ze commented Nov 13, 2023 •

edited

Loading

Uh oh!

robot-clickhouse-ci-1 commented Nov 13, 2023 •

edited by robot-clickhouse

Loading

Uh oh!

mkmkme commented Nov 13, 2023

Uh oh!

rschu1ze commented Nov 13, 2023

Uh oh!

This comment was marked as resolved.

mkmkme commented Nov 14, 2023 •

edited

Loading

Uh oh!

rschu1ze commented Nov 14, 2023

Uh oh!

rschu1ze commented Nov 14, 2023

Uh oh!

Algunenano left a comment

Uh oh!

rschu1ze commented Nov 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

rschu1ze commented Nov 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Uh oh!

robot-clickhouse-ci-1 commented Nov 13, 2023 • edited by robot-clickhouse Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mkmkme commented Nov 13, 2023

Uh oh!

rschu1ze commented Nov 13, 2023

Uh oh!

This comment was marked as resolved.

mkmkme commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rschu1ze commented Nov 14, 2023

Uh oh!

rschu1ze commented Nov 14, 2023

Uh oh!

Algunenano left a comment

Choose a reason for hiding this comment

Uh oh!

rschu1ze commented Nov 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rschu1ze commented Nov 13, 2023 •

edited

Loading

robot-clickhouse-ci-1 commented Nov 13, 2023 •

edited by robot-clickhouse

Loading

mkmkme commented Nov 14, 2023 •

edited

Loading