Skip to content

Analyzer: fix logical error with set in array join#56587

Merged
alexey-milovidov merged 4 commits intomasterfrom
vdimir/analyzer_array_join_set_error
Nov 15, 2023
Merged

Analyzer: fix logical error with set in array join#56587
alexey-milovidov merged 4 commits intomasterfrom
vdimir/analyzer_array_join_set_error

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Nov 10, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 10, 2023
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Nov 10, 2023 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit 11b8395 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@alexey-milovidov alexey-milovidov self-assigned this Nov 10, 2023
@vdimir vdimir mentioned this pull request Nov 10, 2023
Closed
kitaisreal
kitaisreal suggested changes Nov 10, 2023
View reviewed changes
@vdimir vdimir force-pushed the vdimir/analyzer_array_join_set_error branch from 1ed05f1 to b4aa691 Compare November 13, 2023 15:17
@vdimir vdimir force-pushed the vdimir/analyzer_array_join_set_error branch from b4aa691 to 3b73780 Compare November 14, 2023 10:36
kitaisreal
kitaisreal suggested changes Nov 14, 2023
View reviewed changes
@vdimir vdimir force-pushed the vdimir/analyzer_array_join_set_error branch from 6b272ad to 11b8395 Compare November 14, 2023 11:07
@alexey-milovidov alexey-milovidov merged commit e72cf78 into master Nov 15, 2023
@alexey-milovidov alexey-milovidov deleted the vdimir/analyzer_array_join_set_error branch November 15, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

+1 more reviewer

@kitaisreal kitaisreal kitaisreal requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vdimir @robot-clickhouse @alexey-milovidov @kitaisreal