Skip to content

Bump gRPC to v1.54.3#56543

Merged
alexey-milovidov merged 7 commits intoClickHouse:masterfrom
rschu1ze:bump-grpc
Nov 13, 2023
Merged

Bump gRPC to v1.54.3#56543
alexey-milovidov merged 7 commits intoClickHouse:masterfrom
rschu1ze:bump-grpc

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Nov 9, 2023

See #56059

(this PR will accumulate multiple version bumps, cf. #56059 (review))

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@rschu1ze rschu1ze changed the title Bump gRPC to v1.48.8 Bump gRPC to v1.48.4 Nov 9, 2023
@robot-ch-test-poll robot-ch-test-poll added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Nov 9, 2023
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Nov 9, 2023 •
edited
Loading

This is an automated comment for commit 28dbfb9 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@rschu1ze rschu1ze changed the title Bump gRPC to v1.48.4 Bump gRPC to v1.49.3 Nov 10, 2023
@rschu1ze rschu1ze changed the title Bump gRPC to v1.49.3 Bump gRPC to v1.54.3 Nov 12, 2023
@rschu1ze rschu1ze marked this pull request as ready for review November 12, 2023 10:57
@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Nov 12, 2023

@Algunenano The PR jumps from v1.47 to v1.54. Like to review/approve?

@alexey-milovidov alexey-milovidov self-assigned this Nov 13, 2023
@alexey-milovidov alexey-milovidov merged commit 213c7cf into ClickHouse:master Nov 13, 2023
@rschu1ze rschu1ze mentioned this pull request Nov 13, 2023
Merged
@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Nov 13, 2023 •
edited
Loading

Clean build (in Arch):

[3350/12406] Building CXX object contrib/grpc/CMakeFiles/grpc.dir/src/core/lib/iomgr/systemd_utils.cc.o
FAILED: contrib/grpc/CMakeFiles/grpc.dir/src/core/lib/iomgr/systemd_utils.cc.o 
/usr/bin/ccache /usr/lib/ccache/bin/clang++ --target=x86_64-linux-gnu --sysroot=/mnt/ch/ClickHouse/cmake/linux/../../contrib/sysroot/linux-x86_64/x86_64-linux-gnu/libc -DCARES_STATICLIB -DHAVE_LIBSYSTEMD -DSTD_EXCEPTION_HAS_STACK_TRACE=1 -DUNALIGNED_OK -DWITH_GZFILEOP -DX86_64 -DZLIB_COMPAT -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -I/mnt/ch/ClickHouse/contrib/grpc/include -I/mnt/ch/ClickHouse/contrib/grpc -I/mnt/ch/ClickHouse/contrib/grpc/third_party/address_sorting/include -I/mnt/ch/ClickHouse/contrib/grpc/src/core/ext/upb-generated -I/mnt/ch/ClickHouse/contrib/grpc/src/core/ext/upbdefs-generated -I/mnt/ch/ClickHouse/contrib/grpc/third_party/upb -I/mnt/ch/ClickHouse/contrib/grpc/third_party/xxhash -I/mnt/ch/ClickHouse/base/glibc-compatibility/memcpy -I/mnt/ch/ClickHouse/contrib/re2 -I/mnt/ch/ClickHouse/contrib/abseil-cpp -isystem /mnt/ch/ClickHouse/contrib/llvm-project/libcxx/include -isystem /mnt/ch/ClickHouse/contrib/llvm-project/libcxxabi/include -isystem /mnt/ch/ClickHouse/contrib/libunwind/include -isystem /mnt/ch/ClickHouse/contrib/zlib-ng -isystem /mnt/ch/ClickHouse/build/contrib/zlib-ng-cmake -isystem /mnt/ch/ClickHouse/contrib/c-ares/src/lib -isystem /mnt/ch/ClickHouse/contrib/c-ares/include -isystem /mnt/ch/ClickHouse/contrib/c-ares-cmake/linux -isystem /mnt/ch/ClickHouse/contrib/boringssl/include --gcc-toolchain=/mnt/ch/ClickHouse/cmake/linux/../../contrib/sysroot/linux-x86_64 -fdiagnostics-color=always -Xclang -fuse-ctor-homing -Wno-enum-constexpr-conversion -fsized-deallocation  -gdwarf-aranges -pipe -mssse3 -msse4.1 -msse4.2 -mpclmul -mpopcnt -fasynchronous-unwind-tables -ffile-prefix-map=/mnt/ch/ClickHouse=. -falign-functions=32 -mbranches-within-32B-boundaries  -fdiagnostics-absolute-paths -fstrict-vtable-pointers -w  -O2 -g -DNDEBUG -O3 -g -gdwarf-4  -fno-pie -std=c++20   -D OS_LINUX -Werror -nostdinc++ -MD -MT contrib/grpc/CMakeFiles/grpc.dir/src/core/lib/iomgr/systemd_utils.cc.o -MF contrib/grpc/CMakeFiles/grpc.dir/src/core/lib/iomgr/systemd_utils.cc.o.d -o contrib/grpc/CMakeFiles/grpc.dir/src/core/lib/iomgr/systemd_utils.cc.o -c /mnt/ch/ClickHouse/contrib/grpc/src/core/lib/iomgr/systemd_utils.cc
/mnt/ch/ClickHouse/contrib/grpc/src/core/lib/iomgr/systemd_utils.cc:26:10: fatal error: 'systemd/sd-daemon.h' file not found
#include <systemd/sd-daemon.h>

Why is this being included in the build to begin with? How does it work in the CI?

@Algunenano Algunenano mentioned this pull request Nov 13, 2023
Merged
@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Nov 13, 2023

Thanks, I took the freedom and fixed this oversight in your reverting PR #56671. I can only assume that package libsystemd-devel is installed in CI ... (with respect to your local build, I am admittedly a bit confused that CMake did not decide to simply omit the systemd dependency - it rather failed at compile time).

@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Nov 13, 2023

Probably it's the other way around. The systemd devel files are present in my system and not in CI, so in my system it tries to include files that won't be accessible (because of sysroot).

Algunenano added a commit to Algunenano/ClickHouse that referenced this pull request Nov 13, 2023
@Algunenano
Revert "Merge pull request ClickHouse#56543 from rschu1ze/bump-grpc"
993f752 
This reverts commit 213c7cf, reversing
changes made to 9ed4774.
Algunenano pushed a commit to Algunenano/ClickHouse that referenced this pull request Nov 13, 2023
@rschu1ze @Algunenano
Revert "Revert "Merge pull request ClickHouse#56543 from rschu1ze/bum…
51e8c58 
…p-grpc""

This reverts commit d4840adfd4708729ed8f969e61116f58ffe2fb18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rschu1ze @robot-ch-test-poll @Algunenano @alexey-milovidov