Skip to content

Analyzer remove unused projection columns#56499

Merged
KochetovNicolai merged 7 commits intoClickHouse:masterfrom
kitaisreal:analyzer-remove-unused-projection-columns
Nov 16, 2023
Merged

Analyzer remove unused projection columns#56499
KochetovNicolai merged 7 commits intoClickHouse:masterfrom
kitaisreal:analyzer-remove-unused-projection-columns

Conversation

@kitaisreal
Copy link
Copy Markdown
Contributor

@kitaisreal kitaisreal commented Nov 9, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@kitaisreal kitaisreal added the can be tested Allows running workflows for external contributors label Nov 9, 2023
kitaisreal
kitaisreal commented Nov 9, 2023
View reviewed changes
src/Analyzer/QueryNode.h Outdated
Copy link
Copy Markdown
Contributor Author

@kitaisreal kitaisreal Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add refactoring of QueryNode and UnionNode to have QueryNodeBase parent class and extract these methods and other common methods into this parent class.

Copy link
Copy Markdown
Member

@novikd novikd Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do the same with TableNode and TableFunctionNode

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 9, 2023
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Nov 9, 2023 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 49e6bad with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@kitaisreal kitaisreal force-pushed the analyzer-remove-unused-projection-columns branch from 3d54dea to aaad85d Compare November 9, 2023 09:51
@kitaisreal kitaisreal mentioned this pull request Nov 9, 2023
Closed
@kitaisreal kitaisreal force-pushed the analyzer-remove-unused-projection-columns branch from a267046 to 74c5304 Compare November 9, 2023 16:40
@KochetovNicolai
Copy link
Copy Markdown
Member

KochetovNicolai commented Nov 12, 2023

Some tests with analyzer are failed. We need to fix it.

@kitaisreal kitaisreal force-pushed the analyzer-remove-unused-projection-columns branch from 0e1f85a to 257d460 Compare November 14, 2023 11:39
@kitaisreal kitaisreal force-pushed the analyzer-remove-unused-projection-columns branch from 257d460 to 1351863 Compare November 14, 2023 18:26
novikd
novikd approved these changes Nov 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@novikd novikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Analyzer/QueryNode.h Outdated
Copy link
Copy Markdown
Member

@novikd novikd Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to do the same with TableNode and TableFunctionNode

@novikd novikd self-assigned this Nov 16, 2023
@KochetovNicolai KochetovNicolai merged commit 78dfbbf into ClickHouse:master Nov 16, 2023
Algunenano
Algunenano reviewed Nov 20, 2023
View reviewed changes
tests/analyzer_tech_debt.txt
01244_optimize_distributed_group_by_sharding_key
01268_mv_scalars
01268_shard_avgweighted
01287_max_execution_speed
Copy link
Copy Markdown
Member

@Algunenano Algunenano Nov 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No matter how many times this test is removed from the list, it's flaky with the analyzer and the analyzer only and it needs fixing. See https://s3.amazonaws.com/clickhouse-test-reports/56984/ff438112e95568bb322c9ff8283e6b7f2e1b412a/stateless_tests__release__analyzer_.html

5 failures in 24 hours. All with the analyzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano left review comments

@novikd novikd novikd approved these changes

@KochetovNicolai KochetovNicolai Awaiting requested review from KochetovNicolai

Assignees

@novikd novikd

Labels

can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kitaisreal @robot-ch-test-poll3 @KochetovNicolai @Algunenano @novikd