Skip to content

Fix inconsistency of "cast('0' as DateTime64(3))" and "cast('0' as Nullable(DateTime64(3)))"#56286

Merged
Algunenano merged 2 commits intoClickHouse:masterfrom
bigo-sg:ch_56285
Nov 6, 2023
Merged

Fix inconsistency of "cast('0' as DateTime64(3))" and "cast('0' as Nullable(DateTime64(3)))"#56286
Algunenano merged 2 commits intoClickHouse:masterfrom
bigo-sg:ch_56285

Conversation

@taiyang-li
Copy link
Copy Markdown
Contributor

@taiyang-li taiyang-li commented Nov 3, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix issue #56285

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label Nov 3, 2023
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Nov 3, 2023 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 3c70b9f with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@taiyang-li taiyang-li changed the title Fix issue https://github.com/ClickHouse/ClickHouse/issues/56285 Fix inconsistency of cast('0' as DateTime64(3)) and cast('0' as Nullable(DateTime64(3))) Nov 3, 2023
@taiyang-li taiyang-li changed the title Fix inconsistency of cast('0' as DateTime64(3)) and cast('0' as Nullable(DateTime64(3))) Fix inconsistency of "cast('0' as DateTime64(3))" and "cast('0' as Nullable(DateTime64(3)))" Nov 3, 2023
@taiyang-li taiyang-li marked this pull request as ready for review November 3, 2023 07:35
@taiyang-li taiyang-li mentioned this pull request Nov 3, 2023
Open
@Algunenano Algunenano self-assigned this Nov 3, 2023
@Algunenano Algunenano added v23.10-must-backport pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Nov 3, 2023
@zvonand
Copy link
Copy Markdown
Contributor

zvonand commented Nov 3, 2023

See my comment to the issue

@taiyang-li
Copy link
Copy Markdown
Contributor Author

taiyang-li commented Nov 4, 2023

Failed integration tests not related to this pr: https://s3.amazonaws.com/clickhouse-test-reports/56286/3c70b9f65d38e221db5a72f345741f16258680d8/integration_tests__asan__[2_6].html

@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Nov 6, 2023

Test failures are unrelated and already reported.

@Algunenano Algunenano merged commit 653a51a into ClickHouse:master Nov 6, 2023
This was referenced Nov 6, 2023
Closed
Closed
Closed
Merged
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Nov 6, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Nov 6, 2023
@robot-clickhouse
Backport #56286 to 23.10: Fix inconsistency of "cast('0' as DateTime6…
9c29157 
…4(3))" and "cast('0' as Nullable(DateTime64(3)))"
@robot-ch-test-poll robot-ch-test-poll added pr-backports-created-cloud deprecated label, NOOP pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore labels Nov 6, 2023
robot-ch-test-poll4 added a commit that referenced this pull request Nov 6, 2023
@robot-ch-test-poll4
Merge pull request #56366 from ClickHouse/backport/23.10/56286
471d7b2 
Backport #56286 to 23.10: Fix inconsistency of "cast('0' as DateTime64(3))" and "cast('0' as Nullable(DateTime64(3)))"
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 7, 2023
@baibaichen
Reopen ignore uts(apache#3555) due to fix(ClickHouse/ClickHouse#56286)
2a8c019
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 7, 2023
@baibaichen
Reopen ignore uts(apache#3530) due to fix(ClickHouse/ClickHouse#56286)
37fc236
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 7, 2023
@baibaichen
Reopen ignore uts(https://github.com/oap-project/gluten/pull/3555/com…
d83233d 
…mits) due to fix(ClickHouse/ClickHouse#56286)
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 7, 2023
@baibaichen
Reopen ignore uts(https://github.com/oap-project/gluten/pull/3530/com…
093c33f 
…mits) due to fix(ClickHouse/ClickHouse#56286)
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 7, 2023
@baibaichen
Reopen ignore [uts](https://github.com/oap-project/gluten/pull/3530/c…
c3c7b1c 
…ommits) due to [fix](ClickHouse/ClickHouse#56286)
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 7, 2023
@baibaichen
Reopen ignore [uts](https://github.com/oap-project/gluten/pull/3530/c…
d3da949 
…ommits) due to [fix](ClickHouse/ClickHouse#56286)
@baibaichen baibaichen mentioned this pull request Nov 8, 2023
Merged
zzcclp pushed a commit to apache/gluten that referenced this pull request Nov 8, 2023
@lwz9103 @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20231108) (#3640)
1080543 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20231108)

* Reopen ignore [uts](https://github.com/oap-project/gluten/pull/3530/commits) due to [fix](ClickHouse/ClickHouse#56286)

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@taiyang-li @robot-clickhouse-ci-1 @zvonand @Algunenano @robot-ch-test-poll