Skip to content

Fix incomplete query result for UNION in view() function.#56274

Merged
KochetovNicolai merged 1 commit intomasterfrom
fix-union-with-view
Nov 3, 2023
Merged

Fix incomplete query result for UNION in view() function.#56274
KochetovNicolai merged 1 commit intomasterfrom
fix-union-with-view

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Nov 2, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix incomplete query result for UNION in view() table function.

Also fixes 02366_union_decimal_conversion with analyzer.

@KochetovNicolai KochetovNicolai added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Nov 2, 2023
@KochetovNicolai KochetovNicolai mentioned this pull request Nov 2, 2023
Closed
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label Nov 2, 2023
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Nov 2, 2023 •
edited by robot-clickhouse
Loading

This is an automated comment for commit f08c13a with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Docker image for serversThe check to build and optionally push the mentioned image to docker hub❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@alexey-milovidov alexey-milovidov self-assigned this Nov 2, 2023
@KochetovNicolai
Copy link
Copy Markdown
Member Author

KochetovNicolai commented Nov 3, 2023

test_delayed_replica_failover is flaky

@KochetovNicolai KochetovNicolai merged commit 8707b75 into master Nov 3, 2023
@KochetovNicolai KochetovNicolai deleted the fix-union-with-view branch November 3, 2023 11:45
This was referenced Nov 3, 2023
Closed
Merged
Merged
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Nov 3, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Nov 3, 2023
@robot-clickhouse
Backport #56274 to 23.10: Fix incomplete query result for UNION in vi…
f2edfcf 
…ew() function.
nikitamikhaylov added a commit that referenced this pull request Nov 3, 2023
@nikitamikhaylov
Merge pull request #56301 from ClickHouse/backport/23.10/56274
0e944ab 
Backport #56274 to 23.10: Fix incomplete query result for UNION in view() function.
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created-cloud deprecated label, NOOP label Nov 3, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Nov 16, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Nov 16, 2023
@robot-clickhouse
Backport #56274 to 23.8: Fix incomplete query result for UNION in vie…
792ecb6 
…w() function.
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Nov 16, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Nov 16, 2023
@robot-clickhouse
Backport #56274 to 23.9: Fix incomplete query result for UNION in vie…
dd7b9fa 
…w() function.
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 16, 2023
alexey-milovidov added a commit that referenced this pull request Nov 16, 2023
@alexey-milovidov
Merge pull request #56877 from ClickHouse/backport/23.8/56274
812b95e 
Backport #56274 to 23.8: Fix incomplete query result for UNION in view() function.
alexey-milovidov added a commit that referenced this pull request Nov 16, 2023
@alexey-milovidov
Merge pull request #56878 from ClickHouse/backport/23.9/56274
f8554c1 
Backport #56274 to 23.9: Fix incomplete query result for UNION in view() function.
@SaltTan SaltTan mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KochetovNicolai @robot-ch-test-poll1 @alexey-milovidov @robot-ch-test-poll2 @robot-clickhouse-ci-2