Skip to content

Analyzer: fix 01019_alter_materialized_view_consistent#56246

Merged
vdimir merged 1 commit intomasterfrom
vdimir/analyzer_01019_alter_materialized_view
Nov 3, 2023
Merged

Analyzer: fix 01019_alter_materialized_view_consistent#56246
vdimir merged 1 commit intomasterfrom
vdimir/analyzer_01019_alter_materialized_view

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Nov 2, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 2, 2023
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Nov 2, 2023 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit 5703e09 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

vdimir
vdimir commented Nov 2, 2023
View reviewed changes
src/Storages/StorageMaterializedView.cpp

DatabaseCatalog::instance().updateViewDependency(old_select.select_table_id, table_id, new_select.select_table_id, table_id);

new_metadata.setSelectQuery(new_select);
Copy link
Copy Markdown
Member Author

@vdimir vdimir Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line just sets the same select to new_metadata, see line above

const auto & new_select = new_metadata.select;

vdimir
vdimir commented Nov 2, 2023
View reviewed changes
src/Processors/Transforms/buildPushingToViewsChain.cpp
else
{ InterpreterSelectQuery interpreter(view.query, local_context, SelectQueryOptions());
{
InterpreterSelectQuery interpreter(view.query, local_context, SelectQueryOptions());
Copy link
Copy Markdown
Member Author

@vdimir vdimir Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InterpreterSelectQuery checks that view source matches the query inside. But I suppose it's better to have it on buildPushingToViewsChain level.

@KochetovNicolai KochetovNicolai self-assigned this Nov 2, 2023
@Algunenano Algunenano mentioned this pull request Nov 2, 2023
Closed
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Nov 3, 2023

Integration tests (asan, analyzer) [2/6] — fail: 1, passed: 316 Details

#55090 (or it's broken only on analyzer?)

Stateless tests (release, analyzer) — fail: 1, passed: 5787, skipped: 11 Details

01287_max_execution_speed #56052

Upgrade check (debug) — Logical error thrown (see clickhouse-server.log or logical_errors.txt) Details

#55864

@vdimir vdimir merged commit 86524fc into master Nov 3, 2023
@vdimir vdimir deleted the vdimir/analyzer_01019_alter_materialized_view branch November 3, 2023 10:04
This was referenced Nov 3, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vdimir @robot-clickhouse-ci-2 @KochetovNicolai