Skip to content

Bump gRPC to v1.47.5#56059

Merged
rschu1ze merged 4 commits intoClickHouse:masterfrom
rschu1ze:bump-grpc
Nov 9, 2023
Merged

Bump gRPC to v1.47.5#56059
rschu1ze merged 4 commits intoClickHouse:masterfrom
rschu1ze:bump-grpc

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Oct 26, 2023

See #55916

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-ch-test-poll3 robot-ch-test-poll3 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Oct 26, 2023
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Oct 26, 2023 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit b9fafb5 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@Algunenano Algunenano self-requested a review October 27, 2023 09:22
Algunenano
Algunenano requested changes Oct 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Algunenano Algunenano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GRPC seems to make releases once a month or so. I don't mind if you want to test each one but let's not make another 15 PRs. We can test them incrementally in this PR instead.

@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Oct 27, 2023

Okay, sounds like a plan.

@rschu1ze rschu1ze force-pushed the bump-grpc branch 3 times, most recently from ead94a0 to 0237702 Compare November 3, 2023 12:47
@rschu1ze rschu1ze changed the title Bump gRPC to v1.43.2 Bump gRPC to v1.47.5 Nov 3, 2023
@rschu1ze rschu1ze force-pushed the bump-grpc branch 2 times, most recently from fc59dc6 to 5486ad5 Compare November 6, 2023 20:16
@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Nov 8, 2023

@Felixoid This PR updates a submodule and CI jobs BuilderDebDebug and BuilderBinDarwinAarch64 fail for a reason that I don't understand. Do you know what is going wrong there?

@Felixoid
Copy link
Copy Markdown
Member

Felixoid commented Nov 8, 2023

The output is a bit confusing, yes. It basically says, that the build already failed once in https://s3.amazonaws.com/clickhouse-builds/PRs/56059/85c158894126a840f65b46ebe07f979e8c091193/package_debug/build_log.log

Since you are here, can you add https://github.com/ClickHouse/ClickHouse/blob/master/tests/ci/build_check.py#L354-L358 to https://github.com/ClickHouse/ClickHouse/blob/master/tests/ci/build_check.py#L169, please? It will help to avoid confusing

@Felixoid
Copy link
Copy Markdown
Member

Felixoid commented Nov 8, 2023

See the report https://s3.amazonaws.com/clickhouse-test-reports/56059/85c158894126a840f65b46ebe07f979e8c091193/clickhouse_build_check/report.html, all failed tasks have sparse checkout. I think you need to adjust the sparse configuration for the submodule

@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Nov 8, 2023

Okay, thanks, I did as you said.

@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Nov 8, 2023

I don't mind if you want to test each one but let's not make another 15 PRs. We can test them incrementally in this PR instead.

@Algunenano

Since a bit of extra stuff accumulated in this PR and we jump 5 versions, do you mind approving so we can make a "checkpoint"? Of course, I'd batch multiple updates in a future PR again.

Algunenano
Algunenano approved these changes Nov 9, 2023
View reviewed changes
contrib/sparse-checkout/update-grpc.sh
echo '/*' > $FILES_TO_CHECKOUT
echo '!/test/*' >> $FILES_TO_CHECKOUT
echo '/test/build/*' >> $FILES_TO_CHECKOUT
echo '/test/core/tsi/alts/fake_handshaker/*' >> $FILES_TO_CHECKOUT
Copy link
Copy Markdown
Member

@Algunenano Algunenano Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need these files (both test/build and test/core)? Are they needed for the build to succeed?

Copy link
Copy Markdown
Member Author

@rschu1ze rschu1ze Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, gRPC moved some files around with the result that we now need to check them out (even if it looks silly).

@rschu1ze rschu1ze merged commit 9498638 into ClickHouse:master Nov 9, 2023
This was referenced Nov 9, 2023
Merged
Merged
@rschu1ze rschu1ze mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rschu1ze @robot-ch-test-poll3 @Felixoid @Algunenano