Skip to content

Bump protobuf to v3.19.6#55963

Merged
rschu1ze merged 2 commits intoClickHouse:masterfrom
rschu1ze:bump-protobuf
Oct 24, 2023
Merged

Bump protobuf to v3.19.6#55963
rschu1ze merged 2 commits intoClickHouse:masterfrom
rschu1ze:bump-protobuf

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Oct 24, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Oct 24, 2023
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Oct 24, 2023 •
edited by robot-clickhouse
Loading

This is an automated comment for commit a962161 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@Algunenano Algunenano self-assigned this Oct 24, 2023
Algunenano
Algunenano reviewed Oct 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning for bumping to v3.19.3 and not v3.19.6 or v3.24.3?

@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Oct 24, 2023

Thanks, I somehow missed that there were minor releases after v3.19.3. Okay, let me change this to v3.19.6.

I am deliberately incrementing the versions by major releases (i.e. not jumping directly to v3.24). They change quite a lot between releases and being able to look at the changes in a single major release (instead of changes in N releases) is helpful in case something breaks.

@rschu1ze rschu1ze changed the title Bump protobuf to v3.19.3 Bump protobuf to v3.19.6 Oct 24, 2023
@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Oct 24, 2023

I'd prefer a larger bump (and then backtrack if something fails), specially since this requires updating submodules with every PR, but it's your call.

@rschu1ze rschu1ze merged commit 57df567 into ClickHouse:master Oct 24, 2023
@rschu1ze rschu1ze mentioned this pull request Oct 25, 2023
Merged
yokofly pushed a commit to timeplus-io/proton that referenced this pull request Mar 1, 2025
@yokofly
Upgrade Protobuf (#6111)
d03e5b1 
* Bump protobuf to v3.18.x (ref: ClickHouse/ClickHouse#50400)

* Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#55963)

* Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#50920)

* Update contribe/orc (ref: ClickHouse/ClickHouse#53324)

* Bump protobuf to v21.9 (ref: ClickHouse/ClickHouse#56014)

* Removed unused code in google-protobuf-cmake/CMakeLists.txt (ref: ClickHouse/ClickHouse#56102)

* Bump gRPC to v1.55.4 and protobuf to v22.5 (ref: ClickHouse/ClickHouse#56664)

* Bump gRPC to v1.59 and protobuf to v24.4 (ref: ClickHouse/ClickHouse#56853)

* enable functions in readonly mode (ref: ClickHouse/ClickHouse#42708)

* Introduce more fields for in-source function documentation (ref: ClickHouse/ClickHouse#49300)

* Add ability to convert timeplusd table structure to CapnProto/Protobuf format schema (ref: ClickHouse/ClickHouse#52278)

* Well known protos (ref: ClickHouse/ClickHouse#56741)

* Update protobuf to v25.1 (ref: ClickHouse/ClickHouse#58020)

* fixed unit_tests_dbms build

* Avoid ignoring errors of execute_process() (set COMMAND_ERROR_IS_FATAL=ANY) (ref: ClickHouse/ClickHouse#68267)

* fixed reigsterFunction

* fixed error after rebase
yokofly added a commit to timeplus-io/proton that referenced this pull request Mar 1, 2025
@yokofly
Upgrade Protobuf (#6111)
900634d 
* Bump protobuf to v3.18.x (ref: ClickHouse/ClickHouse#50400)

* Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#55963)

* Bump protobuf to v3.19.6 (ref: ClickHouse/ClickHouse#50920)

* Update contribe/orc (ref: ClickHouse/ClickHouse#53324)

* Bump protobuf to v21.9 (ref: ClickHouse/ClickHouse#56014)

* Removed unused code in google-protobuf-cmake/CMakeLists.txt (ref: ClickHouse/ClickHouse#56102)

* Bump gRPC to v1.55.4 and protobuf to v22.5 (ref: ClickHouse/ClickHouse#56664)

* Bump gRPC to v1.59 and protobuf to v24.4 (ref: ClickHouse/ClickHouse#56853)

* enable functions in readonly mode (ref: ClickHouse/ClickHouse#42708)

* Introduce more fields for in-source function documentation (ref: ClickHouse/ClickHouse#49300)

* Add ability to convert timeplusd table structure to CapnProto/Protobuf format schema (ref: ClickHouse/ClickHouse#52278)

* Well known protos (ref: ClickHouse/ClickHouse#56741)

* Update protobuf to v25.1 (ref: ClickHouse/ClickHouse#58020)

* fixed unit_tests_dbms build

* Avoid ignoring errors of execute_process() (set COMMAND_ERROR_IS_FATAL=ANY) (ref: ClickHouse/ClickHouse#68267)

* fixed reigsterFunction

* fixed error after rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano approved these changes

Assignees

@Algunenano Algunenano

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rschu1ze @robot-clickhouse-ci-2 @Algunenano