S3Queue improvements, part 2 (Ordered mode related only)#55795
Closed
kssenii wants to merge 2 commits intoClickHouse:masterfrom
Closed
S3Queue improvements, part 2 (Ordered mode related only)#55795kssenii wants to merge 2 commits intoClickHouse:masterfrom
kssenii wants to merge 2 commits intoClickHouse:masterfrom
Conversation
robot-ch-test-poll1
added
the
pr-improvement
Contributor
|
This is an automated comment for commit fc1ed16 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Member
Author
|
Will make a more simple solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Make
Orderedprocessing mode safely parallelizable. Continuation of #54422.Before this PR setting
s3queue_processing_threads_numwas disabled (forcefully set to 1) forOrderedmode, because it was unsafe, and for the same reason, distributed processing was unsafe. (See #54422 (comment))