Skip to content

Reuse granule during skip index reading#55683

Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
amosbird:issue-55653
Oct 29, 2023
Merged

Reuse granule during skip index reading#55683
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
amosbird:issue-55653

Conversation

@amosbird
Copy link
Collaborator

@amosbird amosbird commented Oct 16, 2023

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Avoid unnecessary reconstruction of index granules when reading skip indexes. This addresses #55653 (comment) .

@robot-clickhouse
Copy link
Member

robot-clickhouse commented Oct 16, 2023 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 602f01f with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@alexey-milovidov alexey-milovidov self-assigned this Oct 16, 2023
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Oct 16, 2023
@amosbird amosbird force-pushed the issue-55653 branch 2 times, most recently from bfa7fca to 7637b1e Compare October 17, 2023 02:16
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-performance Pull request with some performance improvements label Oct 17, 2023
@amosbird amosbird force-pushed the issue-55653 branch 2 times, most recently from 93acac6 to f35d10f Compare October 18, 2023 05:06
@amosbird
Copy link
Collaborator Author

amosbird commented Oct 18, 2023

Performance Comparison [4/4] — 2 too long, 1 faster

Performance improvement is significant

https://s3.amazonaws.com/clickhouse-test-reports/55683/602f01f6517bc13e6e09815418a1be91f3f0c293/performance_comparison_%5B4_4%5D/report.html

AST fuzzer (asan) — Fuzzer failed (134). See the logs.

Nothing obvious in all logs. It seems the fuzzer itself aborted.

Integration tests (asan) [1/6] — fail: 7, passed: 394

test_postgresql_replica_database_engine_2 FAIL. Unrelated.

Integration tests (release) [1/4] — fail: 1, passed: 634

test_dictionaries_redis FAIL. Unrelated.

Integration tests (tsan) [1/6] — fail: 5, passed: 394

test_postgresql_replica_database_engine_2 FAIL. Unrelated.

@amosbird
Copy link
Collaborator Author

amosbird commented Oct 23, 2023

We can introduce a new min-max index similar to https://sneller.ai/blog/sneller-time-index/ . It will have adaptive granularity and can be configured to always live in memory similar to primary key.

@alexey-milovidov alexey-milovidov merged commit 64b6e68 into ClickHouse:master Oct 29, 2023
@al13n321 al13n321 mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amosbird @robot-clickhouse @alexey-milovidov @robot-ch-test-poll1