Skip to content

Optimize hash join performance when join output has large size#54662

Closed
liuneng1994 wants to merge 23 commits intoClickHouse:masterfrom
liuneng1994:optimize-hash-join
Closed

Optimize hash join performance when join output has large size#54662
liuneng1994 wants to merge 23 commits intoClickHouse:masterfrom
liuneng1994:optimize-hash-join

Conversation

@liuneng1994
Copy link
Copy Markdown
Contributor

@liuneng1994 liuneng1994 commented Sep 15, 2023

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Optimize hash join performance when join output has large size

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@liuneng1994
Copy link
Copy Markdown
Contributor Author

liuneng1994 commented Sep 15, 2023

When join output block has a large size, will use a large amount of memory. By controlling the block size of the output, we can reduce memory usage and improve performance

@baibaichen
Copy link
Copy Markdown
Contributor

baibaichen commented Sep 15, 2023

It looks like similar with #54290, but at different place.

@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Sep 15, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-performance Pull request with some performance improvements pr-status-⏳ labels Sep 15, 2023
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Sep 15, 2023 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit 051a6a3 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@liuneng1994 liuneng1994 force-pushed the optimize-hash-join branch 2 times, most recently from 3fd0788 to 2cf971d Compare December 19, 2023 09:53
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the submodule changed At least one submodule changed in this PR. label Dec 19, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 removed the submodule changed At least one submodule changed in this PR. label Dec 19, 2023
@liuneng1994 liuneng1994 mentioned this pull request Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdimir vdimir vdimir left review comments

Assignees

@vdimir vdimir

Labels

can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.