Skip to content

Fix filtering parts with indexHint for non analyzer#54449

Merged
Avogar merged 1 commit intoClickHouse:masterfrom
azat:parts-prune-indexHint
Sep 19, 2023
Merged

Fix filtering parts with indexHint for non analyzer#54449
Avogar merged 1 commit intoClickHouse:masterfrom
azat:parts-prune-indexHint

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Sep 8, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix filtering parts with indexHint for non analyzer

Fixes: #54185 (cc @KochetovNicolai )

@azat azat mentioned this pull request Sep 8, 2023
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label Sep 8, 2023
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Sep 8, 2023 •
edited by robot-clickhouse
Loading

This is an automated comment for commit ffa82e9 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 error

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch🔴 error
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@azat
Copy link
Copy Markdown
Member Author

azat commented Sep 8, 2023 •
edited
Loading

Bugfix validate check — Changed tests don't reproduce the bug

@azat azat force-pushed the parts-prune-indexHint branch from ce540c2 to ffa82e9 Compare September 8, 2023 16:17
@azat
Copy link
Copy Markdown
Member Author

azat commented Sep 18, 2023

Can someone take a look at this please?

@Avogar Avogar self-assigned this Sep 19, 2023
@Avogar Avogar merged commit d555fdf into ClickHouse:master Sep 19, 2023
@azat azat deleted the parts-prune-indexHint branch September 19, 2023 19:16
@azat
Copy link
Copy Markdown
Member Author

azat commented Sep 19, 2023 •
edited
Loading

There are some conflicts with upstream, that breaks two tests:

  • 00990_hasToken_and_tokenbf
  • 02346_full_text_search

Will take a look, if the fix will be easy then I would prefer to wait for it, otherwise revert this PR for now

@azat azat mentioned this pull request Sep 19, 2023
Merged
@azat
Copy link
Copy Markdown
Member Author

azat commented Sep 19, 2023

Oh, this is actually newly added tests from #54541

@azat azat mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

@KochetovNicolai KochetovNicolai Awaiting requested review from KochetovNicolai

Assignees

@Avogar Avogar

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azat @robot-clickhouse-ci-1 @Avogar