Fix partition id pruning for analyzer. by KochetovNicolai · Pull Request #54185 · ClickHouse/ClickHouse

KochetovNicolai · 2023-09-01T15:46:35Z

Changelog category (leave one):

Not for changelog (changelog entry is not required)

01748_partition_id_pruning

robot-ch-test-poll3 · 2023-09-01T15:47:08Z

This is an automated comment for commit 63c681d with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟢 success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🟢 success
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🟢 success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

novikd

LGTM

novikd · 2023-09-06T14:05:49Z

src/Interpreters/ActionsDAG.h

+    /// Returns a list of nodes representing atomic predicates.
+    static NodeRawConstPtrs extractConjunctionAtoms(const Node * predicate);
+
+    /// Get a list of nodes. For every node, check if it can be compused using allowed subset of inputs.


Suggested change

/// Get a list of nodes. For every node, check if it can be compused using allowed subset of inputs.

/// Get a list of nodes. For every node, check if it can be computed using the allowed subset of inputs.

novikd · 2023-09-06T14:11:25Z

src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp

 #include <DataTypes/DataTypeTuple.h>
 #include <DataTypes/DataTypesNumber.h>
 #include <DataTypes/DataTypeArray.h>
+#include <Functions/IFunction.h>


Seems redundant

novikd · 2023-09-06T14:39:20Z

src/Storages/VirtualColumnUtils.h

 /// Only elements of the outer conjunction are considered, depending only on the columns present in the block.
 /// If `expression_ast` is passed, use it to filter block.
 void filterBlockWithQuery(const ASTPtr & query, Block & block, ContextPtr context, ASTPtr expression_ast = {});
+void filterBlockWithQuery(ActionsDAGPtr dag, Block & block, ContextPtr context);


Probably it's better to add a comment, that this overload should be used in the new infrastructure.

novikd · 2023-09-06T14:46:50Z

src/Interpreters/ActionsDAG.cpp

+    {
+        const ActionsDAG::Node * node;
+        size_t next_child_to_visit = 0;
+        bool can_compute_all_childern = true;


Suggested change

bool can_compute_all_childern = true;

bool can_compute_all_children = true;

azat · 2023-09-08T15:37:42Z

src/Processors/QueryPlan/ReadFromMergeTree.cpp

+        buildIndexes(indexes, query_info.filter_actions_dag, data, parts, context, query_info, metadata_snapshot);
+
+    if (indexes->part_values && indexes->part_values->empty())
+        return std::make_shared<MergeTreeDataSelectAnalysisResult>(MergeTreeDataSelectAnalysisResult{.result = std::move(result)});


This breaks filtering partitions for non-analyzer (should be fixed by #54449) and also it does not work even for analyzer without #52762? (note that it got reverted)

Also I've tried to re-apply #52762, but newly added test in #54449 did not pass either

azat · 2023-10-11T15:44:00Z

src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp

+        return {};
+
+    auto atoms = filter_dag->extractConjunctionAtoms(filter_dag->getOutputs().at(0));
+    atoms = ActionsDAG::filterNodesByAllowedInputs(std::move(atoms), allowed_inputs);


@KochetovNicolai this will not work if the query will have something except for columns from partition by, right?

CREATE TABLE default.forms ( `form_id` FixedString(24), `text_field` String ) ENGINE = MergeTree PRIMARY KEY form_id ORDER BY form_id SETTINGS index_granularity = 8192 insert into forms values ('5840ead423829c1eab29fa97','this is a test');

p620.local :) explain indexes=1 select * from forms where _part like '%foo%' and text_field like '%foo%' settings allow_experimental_analyzer=1 EXPLAIN indexes = 1 SELECT * FROM forms WHERE (_part LIKE '%foo%') AND (text_field LIKE '%foo%') SETTINGS allow_experimental_analyzer = 1 Query id: e23f014a-546e-4eab-9fe4-5c09e8ba2c13 ┌─explain───────────────────────────────────┐ │ Expression ((Project names + Projection)) │ │ Filter │ │ ReadFromMergeTree (default.forms) │ │ Indexes: │ │ PrimaryKey │ │ Condition: true │ │ Parts: 1/1 │ │ Granules: 1/1 │ └───────────────────────────────────────────┘

p620.local :) explain indexes=1 select * from forms where _part like '%foo%' settings allow_experimental_analyzer=1 EXPLAIN indexes = 1 SELECT * FROM forms WHERE _part LIKE '%foo%' SETTINGS allow_experimental_analyzer = 1 Query id: 053ce7a4-fbdb-4f26-86f1-8e3adf8d0c26 ┌─explain────────────────────────────────────────────────────────┐ │ Expression ((Project names + Projection)) │ │ Filter ((WHERE + Change column names to column identifiers)) │ │ ReadFromMergeTree (default.forms) │ └────────────────────────────────────────────────────────────────┘ 3 rows in set. Elapsed: 0.002 sec.

KochetovNicolai added 2 commits September 1, 2023 14:29

Fixing 01748_partition_id_pruning

4cbfca7

Refactor.

46087fd

robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 1, 2023

KochetovNicolai mentioned this pull request Sep 1, 2023

[Umbrella] Analyzer, Planner migration #42648

Closed

novikd self-assigned this Sep 1, 2023

Try fix tests.

63c681d

novikd approved these changes Sep 6, 2023

View reviewed changes

robot-ch-test-poll4 merged commit 8c71582 into master Sep 6, 2023

robot-ch-test-poll4 deleted the analyzer-partition-id-pruning branch September 6, 2023 14:53

azat mentioned this pull request Sep 8, 2023

Fix filtering parts with indexHint for non analyzer #54449

Merged

azat reviewed Sep 8, 2023

View reviewed changes

azat mentioned this pull request Sep 20, 2023

Fix filtering parts with indexHint for non analyzer (resubmit) #54825

Merged

azat reviewed Oct 11, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix partition id pruning for analyzer.#54185

Fix partition id pruning for analyzer.#54185
robot-ch-test-poll4 merged 3 commits intomasterfrom
analyzer-partition-id-pruning

KochetovNicolai commented Sep 1, 2023 •

edited

Loading

Uh oh!

robot-ch-test-poll3 commented Sep 1, 2023 •

edited by robot-ch-test-poll2

Loading

Uh oh!

novikd left a comment

Uh oh!

novikd Sep 6, 2023

Uh oh!

novikd Sep 6, 2023

Uh oh!

novikd Sep 6, 2023

Uh oh!

novikd Sep 6, 2023

Uh oh!

azat Sep 8, 2023 •

edited

Loading

Uh oh!

azat Sep 8, 2023

Uh oh!

azat Oct 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	/// Get a list of nodes. For every node, check if it can be compused using allowed subset of inputs.
	/// Get a list of nodes. For every node, check if it can be computed using the allowed subset of inputs.

	bool can_compute_all_childern = true;
	bool can_compute_all_children = true;

Conversation

KochetovNicolai commented Sep 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Uh oh!

robot-ch-test-poll3 commented Sep 1, 2023 • edited by robot-ch-test-poll2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

novikd left a comment

Choose a reason for hiding this comment

Uh oh!

novikd Sep 6, 2023

Choose a reason for hiding this comment

Uh oh!

novikd Sep 6, 2023

Choose a reason for hiding this comment

Uh oh!

novikd Sep 6, 2023

Choose a reason for hiding this comment

Uh oh!

novikd Sep 6, 2023

Choose a reason for hiding this comment

Uh oh!

azat Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

azat Sep 8, 2023

Choose a reason for hiding this comment

Uh oh!

azat Oct 11, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KochetovNicolai commented Sep 1, 2023 •

edited

Loading

robot-ch-test-poll3 commented Sep 1, 2023 •

edited by robot-ch-test-poll2

Loading

azat Sep 8, 2023 •

edited

Loading