Skip to content

Fix segfault in TableNameHints (with Lazy database)#53849

Merged
tavplubix merged 1 commit intomasterfrom
tavplubix-patch-9
Aug 28, 2023
Merged

Fix segfault in TableNameHints (with Lazy database)#53849
tavplubix merged 1 commit intomasterfrom
tavplubix-patch-9

Conversation

@tavplubix
Copy link
Copy Markdown
Member

@tavplubix tavplubix commented Aug 25, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes #53823

ClickHouse/src/Databases/IDatabase.h

Lines 52 to 55 in a6f89c0

/// This method can return nullptr if it's Lazy database
/// (a database with support for lazy tables loading
/// - it maintains a list of tables but tables are loaded lazily).
virtual const StoragePtr & table() const = 0;

But we don't need StoragePtr, we need only table name

@tavplubix tavplubix requested a review from yariks5s August 25, 2023 16:32
@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 25, 2023
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Aug 25, 2023 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit 8dd3448 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@davenger davenger self-assigned this Aug 25, 2023
@tavplubix tavplubix added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Aug 25, 2023
@tavplubix
Copy link
Copy Markdown
Member Author

tavplubix commented Aug 28, 2023

Stateless tests (aarch64) - deadlock due to race condition between RESTART REPLICAS (StorageReplicatedMergeTree::startup()) and DROP DATABASE (StorageReplicatedMergeTree::flushAndPrepareForShutdown())
Stateless tests (tsan, s3 storage) [5/5] - 00002_log_and_exception_messages_formatting is flaky

Both fixed in #53892

@tavplubix tavplubix merged commit 98e6a6b into master Aug 28, 2023
@tavplubix tavplubix deleted the tavplubix-patch-9 branch August 28, 2023 15:51
This was referenced Aug 28, 2023
Closed
Closed
Closed
Closed
Closed
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davenger davenger davenger approved these changes

@yariks5s yariks5s Awaiting requested review from yariks5s

Assignees

@davenger davenger

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segfault in DB::TableNameHints::getAllRegisteredNames() during drop query

4 participants

@tavplubix @robot-ch-test-poll @davenger @robot-ch-test-poll3