Skip to content

Revert "Revert "Planner prepare filters for analysis""#53792

Merged
Algunenano merged 5 commits intomasterfrom
revert-53782-revert-52762-planner-prepare-filters-for-analysis
Oct 16, 2023
Merged

Revert "Revert "Planner prepare filters for analysis""#53792
Algunenano merged 5 commits intomasterfrom
revert-53782-revert-52762-planner-prepare-filters-for-analysis

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Aug 24, 2023 •
edited
Loading

Reverts #53782

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

KochetovNicolai and others added 2 commits August 24, 2023 12:32
@KochetovNicolai
Revert "Revert "Planner prepare filters for analysis""
93ab531
@KochetovNicolai
Fix 02834_remote_session_log
6128146 
(cherry picked from commit 40a84e48aae09aff08850e19c5527fd9bcf4ab8e)
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 24, 2023
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Aug 24, 2023 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit 0b4d767 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

Algunenano
Algunenano reviewed Aug 24, 2023
View reviewed changes
@novikd novikd self-assigned this Aug 24, 2023
@Algunenano Algunenano mentioned this pull request Aug 29, 2023
Merged
5 tasks
novikd
novikd approved these changes Aug 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@novikd novikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but merged with master to check failed tests.

@novikd novikd mentioned this pull request Sep 13, 2023
Merged
@devcrafter
Copy link
Copy Markdown
Member

devcrafter commented Oct 10, 2023

Something wrong happened in test_drop_is_lock_free/test.py::test_query_is_permanent[detach-part-TxNotFinished]

https://pastila.nl/?0014f436/83ba616b3eb369d159d3e8f299f0119e#qsR8c8RpXWFX1PrTA6N72Q==

@Algunenano Algunenano self-assigned this Oct 16, 2023
@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Oct 16, 2023

Having a look at the PR since it's useful to implement parallel replicas decision on top of the analyzer.

  • test_query_is_lock_free[detach table] currently ignored with the analyzer. It's a different error message and seems ok to adapt (there are similar fixes in other tests).
  • test_query_is_permanent[detach-part-TxNotFinished]. It failed to wait for the locking query to start. The logs have been rolled out.

The query did run:

SELECT
    event_date,
    event_time_microseconds,
    type AS query
FROM system.query_log
WHERE query_id = 'select-table_test_query_is_permanent_detach_part_TxNotFinished_'

Query id: 9ab6c16f-c095-4960-a3e1-9fb9911dd1cd

┌─event_date─┬────event_time_microseconds─┬─query───────┐
│ 2023-10-09 │ 2023-10-09 18:25:57.720389 │ QueryStart  │
│ 2023-10-09 │ 2023-10-09 18:26:03.736292 │ QueryFinish │
└────────────┴────────────────────────────┴─────────────┘

Checking query logs:

┌─event_date─┬────event_time_microseconds─┬─query────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ 2023-10-09 │ 2023-10-09 18:25:57.727613 │ SELECT count() FROM system.processes WHERE query_id = 'select-table_test_query_is_permanent_detach_part_TxNotFinished_'; │
│ 2023-10-09 │ 2023-10-09 18:25:58.435441 │ SELECT count() FROM system.processes WHERE query_id = 'select-table_test_query_is_permanent_detach_part_TxNotFinished_'; │
│ 2023-10-09 │ 2023-10-09 18:25:58.601061 │ SELECT count() FROM system.processes WHERE query_id = 'select-table_test_query_is_permanent_detach_part_TxNotFinished_'; │
│ 2023-10-09 │ 2023-10-09 18:25:59.879914 │ SELECT count() FROM system.processes WHERE query_id = 'select-table_test_query_is_permanent_detach_part_TxNotFinished_'; │
│ 2023-10-09 │ 2023-10-09 18:26:01.232269 │ SELECT count() FROM system.processes WHERE query_id = 'select-table_test_query_is_permanent_detach_part_TxNotFinished_'; │
│ 2023-10-09 │ 2023-10-09 18:26:02.645145 │ SELECT count() FROM system.processes WHERE query_id = 'select-table_test_query_is_permanent_detach_part_TxNotFinished_'; │
│ 2023-10-09 │ 2023-10-09 18:26:03.798331 │ SELECT count() FROM system.processes WHERE query_id = 'select-table_test_query_is_permanent_detach_part_TxNotFinished_'; │
└────────────┴────────────────────────────┴──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

The problem seems to be that the query finished before the last check (after the query starts there are 5 checks separated by 1 second each).

The followup question would be why did the query finish if it's supposed to sleep for 3 x 50 seconds? The logs confirm it should have slept for that time: 'SleepFunctionCalls':50,'SleepFunctionMicroseconds':150000000, but it only lasted for 6 seconds (query_duration_ms: 6015) so the query did not do what's supposed to have done. In any case, it's unrelated to the changes.

@Algunenano Algunenano mentioned this pull request Oct 16, 2023
Closed
@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Oct 16, 2023

Reported the sleep problem here and I'll open a different PR to enable the test_query_is_lock_free[detach table] test with the analyzer.

@Algunenano Algunenano merged commit 478f635 into master Oct 16, 2023
@Algunenano Algunenano deleted the revert-53782-revert-52762-planner-prepare-filters-for-analysis branch October 16, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Algunenano Algunenano Algunenano left review comments

@novikd novikd novikd approved these changes

Assignees

@Algunenano Algunenano

@novikd novikd

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KochetovNicolai @robot-clickhouse-ci-2 @devcrafter @Algunenano @novikd