Skip to content

Fix broken 02862_sorted_distinct_sparse_fix#53738

Merged
KochetovNicolai merged 1 commit intomasterfrom
fix-02862_sorted_distinct_sparse_fix
Aug 23, 2023
Merged

Fix broken 02862_sorted_distinct_sparse_fix#53738
KochetovNicolai merged 1 commit intomasterfrom
fix-02862_sorted_distinct_sparse_fix

Conversation

@antonio2368
Copy link
Copy Markdown
Member

@antonio2368 antonio2368 commented Aug 23, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

cc @devcrafter @alexey-milovidov this should be also applied to all backport PRs

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@antonio2368 antonio2368 mentioned this pull request Aug 23, 2023
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 23, 2023
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Aug 23, 2023 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit 240d29b with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success

@nikitamikhaylov nikitamikhaylov self-assigned this Aug 23, 2023
devcrafter
devcrafter reviewed Aug 23, 2023
View reviewed changes
tests/queries/0_stateless/02862_sorted_distinct_sparse_fix.reference
select trimLeft(explain) from (explain pipeline SELECT DISTINCT id, v FROM t_sparse_distinct) where explain ilike '%DistinctSortedChunkTransform%';
DistinctSortedChunkTransform
SELECT DISTINCT id, v FROM t_sparse_distinct format Null;
DROP TABLE t_sparse_distinct;
Copy link
Copy Markdown
Member

@devcrafter devcrafter Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather add -- { echoOff } in sql file before DROP statement

Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge to fix fasttest faster

@KochetovNicolai KochetovNicolai merged commit 6d6d5f5 into master Aug 23, 2023
@KochetovNicolai KochetovNicolai deleted the fix-02862_sorted_distinct_sparse_fix branch August 23, 2023 10:28
@devcrafter devcrafter added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Aug 23, 2023
This was referenced Aug 23, 2023
Closed
Closed
Closed
Closed
Closed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created-cloud deprecated label, NOOP label Aug 23, 2023
@devcrafter devcrafter added pr-must-backport Pull request should be backported intentionally. Use this label with great care! and removed pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Aug 24, 2023
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Aug 24, 2023
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Aug 24, 2023
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Aug 24, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Aug 24, 2023
@robot-clickhouse
Backport #53738 to 22.8: Fix broken 02862_sorted_distinct_sparse_fix
b6d6387
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Aug 24, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Aug 24, 2023
@robot-clickhouse
Backport #53738 to 23.7: Fix broken 02862_sorted_distinct_sparse_fix
ac998d9
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 24, 2023
devcrafter added a commit that referenced this pull request Aug 25, 2023
@devcrafter
Merge pull request #53810 from ClickHouse/backport/23.7/53738
e86c21f 
Backport #53738 to 23.7: Fix broken `02862_sorted_distinct_sparse_fix`
devcrafter added a commit that referenced this pull request Aug 25, 2023
@devcrafter
Merge pull request #53809 from ClickHouse/backport/22.8/53738
8feecff 
Backport #53738 to 22.8: Fix broken `02862_sorted_distinct_sparse_fix`
@devcrafter devcrafter added v23.3-must-backport and removed pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore labels Aug 28, 2023
This was referenced Aug 28, 2023
Merged
Merged
@robot-clickhouse robot-clickhouse mentioned this pull request Aug 28, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Aug 28, 2023
@robot-clickhouse
Backport #53738 to 23.5: Fix broken 02862_sorted_distinct_sparse_fix
6443452
@robot-clickhouse robot-clickhouse mentioned this pull request Aug 28, 2023
Merged
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Aug 28, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Aug 28, 2023
@robot-clickhouse
Backport #53738 to 23.3: Fix broken 02862_sorted_distinct_sparse_fix
c70c58e
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Aug 28, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Aug 28, 2023
@robot-clickhouse
Backport #53738 to 23.6: Fix broken 02862_sorted_distinct_sparse_fix
194b443
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 28, 2023
devcrafter added a commit that referenced this pull request Aug 29, 2023
@devcrafter
Merge pull request #53884 from ClickHouse/backport/23.5/53738
be71693 
Backport #53738 to 23.5: Fix broken `02862_sorted_distinct_sparse_fix`
devcrafter added a commit that referenced this pull request Aug 29, 2023
@devcrafter
Merge pull request #53888 from ClickHouse/backport/23.3/53738
4abaccd 
Backport #53738 to 23.3: Fix broken `02862_sorted_distinct_sparse_fix`
devcrafter added a commit that referenced this pull request Aug 29, 2023
@devcrafter
Merge pull request #53889 from ClickHouse/backport/23.6/53738
6008384 
Backport #53738 to 23.6: Fix broken `02862_sorted_distinct_sparse_fix`
@Enmk Enmk mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devcrafter devcrafter devcrafter left review comments

@KochetovNicolai KochetovNicolai KochetovNicolai left review comments

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@antonio2368 @robot-clickhouse-ci-2 @devcrafter @KochetovNicolai @nikitamikhaylov @robot-ch-test-poll4 @robot-ch-test-poll3