Skip to content

Fix: sorted distinct with sparse columns#53711

Merged
alexey-milovidov merged 2 commits intomasterfrom
sorted-distinct-sparse-columns
Aug 23, 2023
Merged

Fix: sorted distinct with sparse columns#53711
alexey-milovidov merged 2 commits intomasterfrom
sorted-distinct-sparse-columns

Conversation

@devcrafter
Copy link
Copy Markdown
Member

@devcrafter devcrafter commented Aug 22, 2023

Fixes #52540

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixes possible crashes in DISTINCT queries with enabled optimize_distinct_in_order and sparse columns

@devcrafter devcrafter mentioned this pull request Aug 22, 2023
Closed
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-bugfix Pull request with bugfix, not backported by default label Aug 22, 2023
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Aug 22, 2023 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit b4cc0f0 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success

@devcrafter
Copy link
Copy Markdown
Member Author

devcrafter commented Aug 22, 2023

The report which clarified the crash - https://s3.amazonaws.com/clickhouse-test-reports/0/90e8069681efaad9fa64b854b66470856cea7b04/sqlancer__debug_.html

Stack - https://pastila.nl/?000e6f9a/96c7175c42567ca7c0dbe46c78a6f049#6rJqrejLC+ixTDd1nL/THw==

@devcrafter
Copy link
Copy Markdown
Member Author

devcrafter commented Aug 23, 2023

Upgrade check failure - fixed in #53611

@alexey-milovidov alexey-milovidov added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Aug 23, 2023
@alexey-milovidov alexey-milovidov self-assigned this Aug 23, 2023
@alexey-milovidov alexey-milovidov merged commit 67c3b7f into master Aug 23, 2023
@alexey-milovidov alexey-milovidov deleted the sorted-distinct-sparse-columns branch August 23, 2023 08:34
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 23, 2023
Merged
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 23, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Aug 23, 2023
@robot-clickhouse
Backport #53711 to 22.8: Fix: sorted distinct with sparse columns
0563c54
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 23, 2023
Merged
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 23, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Aug 23, 2023
@robot-clickhouse
Backport #53711 to 23.3: Fix: sorted distinct with sparse columns
1a9560b
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 23, 2023
Merged
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 23, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Aug 23, 2023
@robot-clickhouse
Backport #53711 to 23.5: Fix: sorted distinct with sparse columns
d054d3a
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 23, 2023
Merged
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 23, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Aug 23, 2023
@robot-clickhouse
Backport #53711 to 23.6: Fix: sorted distinct with sparse columns
63fdf2b
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 23, 2023
Merged
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Aug 23, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Aug 23, 2023
@robot-clickhouse
Backport #53711 to 23.7: Fix: sorted distinct with sparse columns
ccdfe61
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 23, 2023
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created-cloud deprecated label, NOOP label Aug 23, 2023
@antonio2368
Copy link
Copy Markdown
Member

antonio2368 commented Aug 23, 2023

This broke FastTest

@antonio2368
Copy link
Copy Markdown
Member

antonio2368 commented Aug 23, 2023

Fix #53738

@marising marising mentioned this pull request Aug 23, 2023
Closed
devcrafter added a commit that referenced this pull request Aug 24, 2023
@devcrafter
Merge pull request #53732 from ClickHouse/backport/23.7/53711
4530a41 
Backport #53711 to 23.7: Fix: sorted distinct with sparse columns
devcrafter added a commit that referenced this pull request Aug 24, 2023
@devcrafter
Merge pull request #53729 from ClickHouse/backport/23.6/53711
6f1bd65 
Backport #53711 to 23.6: Fix: sorted distinct with sparse columns
devcrafter added a commit that referenced this pull request Aug 24, 2023
@devcrafter
Merge pull request #53727 from ClickHouse/backport/23.5/53711
d15f2c1 
Backport #53711 to 23.5: Fix: sorted distinct with sparse columns
devcrafter added a commit that referenced this pull request Aug 24, 2023
@devcrafter
Merge pull request #53725 from ClickHouse/backport/23.3/53711
b069bdd 
Backport #53711 to 23.3: Fix: sorted distinct with sparse columns
devcrafter added a commit that referenced this pull request Aug 24, 2023
@devcrafter
Merge pull request #53723 from ClickHouse/backport/22.8/53711
7a0da1d 
Backport #53711 to 22.8: Fix: sorted distinct with sparse columns
@SmitaRKulkarni SmitaRKulkarni mentioned this pull request Aug 24, 2023
Merged
@Enmk Enmk mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Null pointer DistinctSortedChunkTransform.cpp

6 participants

@devcrafter @robot-ch-test-poll2 @antonio2368 @alexey-milovidov @robot-ch-test-poll @robot-ch-test-poll4