Add statement `SYSTEM RELOAD ASYNCHRONOUS METRICS` by rschu1ze · Pull Request #53710 · ClickHouse/ClickHouse

rschu1ze · 2023-08-22T21:40:29Z

This PR was born out of an annoyance with integration tests where it was necessary to prepend SELECT * FROM system.asynchronous_metrics with sleep(sth > asynchronous_metrics_update_interval) to make sure the system tables are up-to-date.

Commits:

Some cosmetics 1262945
Refactor the locking (it was a bit weird before) into two mutexes 748371d
Add SYSTEM RELOAD ASYNCHRONOUS METRICS 90a0ea3

Changelog category (leave one):

New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added statement SYSTEM RELOAD ASYNCHRONOUS METRICS which updates the asynchronous metrics. Mostly useful for testing and development.

robot-ch-test-poll2 · 2023-08-22T21:42:15Z

This is an automated comment for commit 8fc918b with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker server and keeper images	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Docs check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Fast tests	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Unit tests	Runs the unit tests for different release types	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	❌ failure

alexey-milovidov · 2023-08-22T22:19:14Z

Ok.

Caveats:

there are AsynchronousMetrics and heavier, ServerAsynchronousMetrics (both need to be updated).
take care of AsynchronousMetricsUpdateInterval and Jitter metrics.

antonio2368 · 2023-08-23T11:20:24Z

there are AsynchronousMetrics and heavier, ServerAsynchronousMetrics (both need to be updated).

Not sure I understand this part, but AsynchronousMetrics is just base class for ServerAsynchronousMetrics which will call all updates in update, both from base class and from derived.
Server defines only one object for async metrics.

rschu1ze · 2024-01-19T00:46:38Z

I refreshed this PR after a long time. Alexey's points are addressed.

@antonio2368 maybe you like to take a look? (I guess this PR appears so far in the open PR list on GitHub that nobody will assign 😄)

antonio2368 · 2024-01-22T10:01:19Z

tests/queries/0_stateless/02970_system_reload_asynchronous_metrics.sql

you can make a much better test
set asynchronous_metrics_update_period_s to a really large value
and then pick a metric, e.g. Uptime or NumberOfTables to check in system.asynchronous_metrics it's updated after this call

Done, thanks.

antonio2368 · 2024-01-22T10:02:38Z

src/Interpreters/InterpreterSystemQuery.cpp

now I see what Alexey was saying
In server metrics there is updateHeavyMetricsIfNeeded which has a different update interval.
They won't be updated with this call unless the interval has passed since last update.
I think you need to add a new argument bool force to update and updateImpl which will ignore such checks.

Right, thanks. Updated.

rschu1ze · 2024-01-22T17:20:33Z

There were Tsan issues and weird results (probably due to races) in previous commits.
These should be gone with the reworked locking.

…ync-metrics Minor follow-up to #53710

robot-ch-test-poll2 added the pr-feature Pull request with new product feature label Aug 22, 2023

rschu1ze changed the title ~~Add statement 'SYSTEM RELOAD ASYNCHRONOUS METRICS'~~ Add statement SYSTEM RELOAD ASYNCHRONOUS METRICS Jan 18, 2024

rschu1ze marked this pull request as ready for review January 19, 2024 00:40

rschu1ze force-pushed the system-reload-asynchronous-metrics branch from f54d896 to 0929b09 Compare January 20, 2024 23:04

antonio2368 reviewed Jan 22, 2024

View reviewed changes

rschu1ze added 3 commits January 22, 2024 16:51

Cosmetics

1262945

Refactor locking in AsynchronousMetrics

748371d

Add statement 'SYSTEM RELOAD ASYNCHRONOUS METRICS'

90a0ea3

rschu1ze force-pushed the system-reload-asynchronous-metrics branch from 0929b09 to 90a0ea3 Compare January 22, 2024 17:15

Remove obsolete test

c0868ee

rschu1ze added 3 commits January 22, 2024 17:37

Fix style

d739a72

Fix style, pt. II

e72b44a

Fix style, pt. III

8fc918b

antonio2368 approved these changes Jan 23, 2024

View reviewed changes

rschu1ze merged commit e23e7e6 into ClickHouse:master Jan 23, 2024

rschu1ze added a commit that referenced this pull request Jan 23, 2024

Merge pull request #59109 from rschu1ze/follow-up-to-system-reload-as…

f7a314e

…ync-metrics Minor follow-up to #53710

This was referenced Mar 26, 2024

Fix flaky tests 2 (stateless, integration) #61869

Merged

Document SYSTEM RELOAD ASYNCHRONOUS METRICS #62164

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add statement `SYSTEM RELOAD ASYNCHRONOUS METRICS`#53710

Add statement `SYSTEM RELOAD ASYNCHRONOUS METRICS`#53710
rschu1ze merged 7 commits intoClickHouse:masterfrom
rschu1ze:system-reload-asynchronous-metrics

rschu1ze commented Aug 22, 2023 •

edited

Loading

Uh oh!

robot-ch-test-poll2 commented Aug 22, 2023 •

edited by robot-ch-test-poll4

Loading

Uh oh!

alexey-milovidov commented Aug 22, 2023 •

edited

Loading

Uh oh!

antonio2368 commented Aug 23, 2023

Uh oh!

rschu1ze commented Jan 19, 2024

Uh oh!

antonio2368 Jan 22, 2024

Uh oh!

rschu1ze Jan 22, 2024

Uh oh!

antonio2368 Jan 22, 2024

Uh oh!

rschu1ze Jan 22, 2024

Uh oh!

rschu1ze commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

rschu1ze commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Uh oh!

robot-ch-test-poll2 commented Aug 22, 2023 • edited by robot-ch-test-poll4 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexey-milovidov commented Aug 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonio2368 commented Aug 23, 2023

Uh oh!

rschu1ze commented Jan 19, 2024

Uh oh!

antonio2368 Jan 22, 2024

Choose a reason for hiding this comment

Uh oh!

rschu1ze Jan 22, 2024

Choose a reason for hiding this comment

Uh oh!

antonio2368 Jan 22, 2024

Choose a reason for hiding this comment

Uh oh!

rschu1ze Jan 22, 2024

Choose a reason for hiding this comment

Uh oh!

rschu1ze commented Jan 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rschu1ze commented Aug 22, 2023 •

edited

Loading

robot-ch-test-poll2 commented Aug 22, 2023 •

edited by robot-ch-test-poll4

Loading

alexey-milovidov commented Aug 22, 2023 •

edited

Loading