Skip to content

Analyzer: always qualify execution names#53705

Merged
KochetovNicolai merged 38 commits intomasterfrom
analyzer-execution-names
Jan 6, 2024
Merged

Analyzer: always qualify execution names#53705
KochetovNicolai merged 38 commits intomasterfrom
analyzer-execution-names

Conversation

@novikd
Copy link
Copy Markdown
Member

@novikd novikd commented Aug 22, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Refactor generation of execution names:

  • Remove suffixes.
  • Generate unique aliases for each table expression.
  • Use source alias as a qualifier in execution name creation.

cc @KochetovNicolai

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 22, 2023
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Aug 22, 2023 •
edited by robot-ch-test-poll1
Loading

This is an automated comment for commit da76f51 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc❌ failure

devcrafter
devcrafter reviewed Aug 25, 2023
View reviewed changes
@robot-clickhouse robot-clickhouse added the submodule changed At least one submodule changed in this PR. label Dec 13, 2023
@KochetovNicolai KochetovNicolai removed the submodule changed At least one submodule changed in this PR. label Dec 13, 2023
@KochetovNicolai KochetovNicolai force-pushed the analyzer-execution-names branch from 1f36fa9 to 676b913 Compare December 14, 2023 13:53
@kitaisreal kitaisreal self-assigned this Dec 15, 2023
@KochetovNicolai
Copy link
Copy Markdown
Member

KochetovNicolai commented Dec 16, 2023

At this point, only 02845_table_function_hdfs_filter_by_virtual_columns and 00578_merge_table_and_table_virtual_column are broken with analyzer. This is because virtual columns analysis for hdfs and merge engines is done using AST, which now has a table alias (e.g. __table1._table instead of _table).

I will refactor this in separate PRs.

This was referenced Dec 27, 2023
Merged
Merged
@KochetovNicolai KochetovNicolai marked this pull request as ready for review January 5, 2024 09:32
@KochetovNicolai KochetovNicolai merged commit 105789b into master Jan 6, 2024
@KochetovNicolai KochetovNicolai deleted the analyzer-execution-names branch January 6, 2024 16:39
@novikd novikd mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devcrafter devcrafter devcrafter left review comments

Assignees

@kitaisreal kitaisreal

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@novikd @robot-clickhouse-ci-2 @KochetovNicolai @devcrafter @kitaisreal @robot-clickhouse