Fix adding sub-second intervals to DateTime by al13n321 · Pull Request #53309 · ClickHouse/ClickHouse

al13n321 · 2023-08-11T05:51:20Z

Changelog category (leave one):

Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed adding intervals of a fraction of a second to DateTime producing incorrect result.

:) select toDateTime('2000-01-01') + interval 1 millisecond

Before:

┌─plus(toDateTime('2000-01-01'), toIntervalMillisecond(0))─┐
│                                      2026-10-14 16:21:20 │
└──────────────────────────────────────────────────────────┘

After:

┌─plus(toDateTime('2000-01-01'), toIntervalMillisecond(1))─┐
│                                  2000-01-01 00:00:00.001 │
└──────────────────────────────────────────────────────────┘

It was a simple bug in AddNanosecondsImpl/etc - it was returning a wrong type.

Along the way added a check for this overflow (very incomplete, other overflows remain unchecked):

:) select toDateTime64('3000-01-01 12:00:00.12345', 0) + interval 0 nanosecond

Before:

┌─plus(toDateTime64('3000-01-01 12:00:00.12345', 0), toIntervalNanosecond(0))─┐
│                                               1900-01-01 00:00:00.290448384 │
└─────────────────────────────────────────────────────────────────────────────┘

After:

Received exception:
Code: 407. DB::Exception: Decimal math overflow: While processing toDateTime64('3000-01-01 12:00:00.12345', 0) + toIntervalNanosecond(0). (DECIMAL_OVERFLOW)

And made incompatible types get rejected during typechecking rather than execution:

:) select toTypeName(materialize(toDate('2000-01-01')) + interval 1 nanosecond)

Before:

┌─toTypeName(plus(materialize(toDate('2000-01-01')), toIntervalNanosecond(1)))─┐
│ DateTime64(9)                                                                │
└──────────────────────────────────────────────────────────────────────────────┘

After:

Received exception:
Code: 43. DB::Exception: addNanoseconds cannot be used with Date: While processing toTypeName(materialize(toDate('2000-01-01')) + toIntervalNanosecond(1)). (ILLEGAL_TYPE_OF_ARGUMENT)

robot-ch-test-poll4 · 2023-08-11T05:58:29Z

This is an automated comment for commit 690b0e9 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
Bugfix validate check	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟢 success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🟢 success
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🔴 failure
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

antonio2368 · 2023-08-11T09:13:35Z

src/Functions/FunctionDateOrDateTimeAddInterval.h

+        chassert(false);
+        return 0;


maybe throw a logical error in cases like this?
Returning 0 seems strange on something that shouldn't be called + it could make it harder to debug.

Yeah, that sounds better, changing.

al13n321 · 2023-08-17T01:43:26Z

Stress test (debug): #53454

tavplubix · 2023-08-24T18:02:42Z

The new test is flaky:
https://s3.amazonaws.com/clickhouse-test-reports/0/407bb57ba9b4727b135635d3e6479f9e635b6ded/stateless_tests__release__s3_storage__[1_2].html

https://s3.amazonaws.com/clickhouse-test-reports/53673/61f4b6e2294a13541e8304336b427bcbafb199a9/stateless_tests__debug__s3_storage__[1_6].html

al13n321 · 2023-08-24T20:14:30Z

The new test is flaky:

Wow, a simple toDateTime('2000-01-01 12:00:00') + INTERVAL 1234567 SECOND produced a result that's off by exactly one hour. Must be something related to timezones. But what exactly? The only thing I can think of is session's or server's timezone changing between the toDateTime execution and the formatting of the results; but AFAICT server timezone can't change at runtime and session timezone can't change without the test doing any queries to change it. What else can it be? Am I misunderstanding how timezones work in CH?

tavplubix · 2023-08-25T17:23:12Z

Maybe this is the culprit:

ClickHouse/tests/clickhouse-test

Lines 613 to 624 in 16cbda1

    
           "session_timezone": lambda: random.choice( 
        
               [ 
        
                   # special non-deterministic around 1970 timezone, see [1]. 
        
                   # 
        
                   #   [1]: https://github.com/ClickHouse/ClickHouse/issues/42653 
        
                   "America/Mazatlan", 
        
                   "America/Hermosillo", 
        
                   "Mexico/BajaSur", 
        
                   # server default that is randomized across all timezones 
        
                   # NOTE: due to lots of trickery we cannot use empty timezone here, but this should be the same. 
        
                   get_localzone(), 
        
               ]

al13n321 · 2023-08-28T23:40:52Z

Ah, turns out the real timezone randomization is in docker/test/stateless/run.sh rather than tests/clickhouse-test, that's why I couldn't reproduce it locally. Fix in #53906

Backport #53309 to 23.3: Fix adding sub-second intervals to DateTime

…54983) Co-authored-by: robot-clickhouse <[email protected]>

…54981) Co-authored-by: robot-clickhouse <[email protected]>

robot-ch-test-poll4 added the pr-bugfix Pull request with bugfix, not backported by default label Aug 11, 2023

antonio2368 self-assigned this Aug 11, 2023

antonio2368 reviewed Aug 11, 2023

View reviewed changes

Fix adding sub-second intervals to DateTime

690b0e9

al13n321 force-pushed the int branch from 2d2a9c2 to 690b0e9 Compare August 15, 2023 21:07

antonio2368 approved these changes Aug 21, 2023

View reviewed changes

al13n321 merged commit a5fbac9 into master Aug 21, 2023

al13n321 deleted the int branch August 21, 2023 19:33

tavplubix mentioned this pull request Aug 24, 2023

Added client_info validation to the query packet in TCPHandler. #53673

Merged

tavplubix mentioned this pull request Aug 29, 2023

Follow-up to #53501 #53851

Merged

nikitamikhaylov added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Sep 25, 2023

robot-clickhouse-ci-2 mentioned this pull request Sep 25, 2023

Cherry pick #53309 to 23.3: Fix adding sub-second intervals to DateTime #54978

Merged

robot-clickhouse-ci-2 mentioned this pull request Sep 25, 2023

Backport #53309 to 23.3: Fix adding sub-second intervals to DateTime #54979

Merged

robot-clickhouse added a commit that referenced this pull request Sep 25, 2023

Backport #53309 to 23.3: Fix adding sub-second intervals to DateTime

21c7502

robot-clickhouse-ci-2 mentioned this pull request Sep 25, 2023

Cherry pick #53309 to 23.6: Fix adding sub-second intervals to DateTime #54980

Merged

robot-clickhouse-ci-2 mentioned this pull request Sep 25, 2023

Backport #53309 to 23.6: Fix adding sub-second intervals to DateTime #54981

Merged

robot-clickhouse added a commit that referenced this pull request Sep 25, 2023

Backport #53309 to 23.6: Fix adding sub-second intervals to DateTime

37c2d18

robot-clickhouse-ci-2 mentioned this pull request Sep 25, 2023

Cherry pick #53309 to 23.7: Fix adding sub-second intervals to DateTime #54982

Merged

robot-clickhouse added a commit that referenced this pull request Sep 25, 2023

Backport #53309 to 23.7: Fix adding sub-second intervals to DateTime

6e15966

robot-clickhouse-ci-2 mentioned this pull request Sep 25, 2023

Backport #53309 to 23.7: Fix adding sub-second intervals to DateTime #54983

Merged

robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 25, 2023

robot-ch-test-poll4 added the pr-backports-created-cloud deprecated label, NOOP label Sep 25, 2023

robot-clickhouse-ci-2 added a commit that referenced this pull request Sep 25, 2023

Merge pull request #54979 from ClickHouse/backport/23.3/53309

b969461

Backport #53309 to 23.3: Fix adding sub-second intervals to DateTime

al13n321 pushed a commit that referenced this pull request Sep 26, 2023

Backport #53309 to 23.7: Fix adding sub-second intervals to DateTime (#…

c4606c7

…54983) Co-authored-by: robot-clickhouse <[email protected]>

al13n321 pushed a commit that referenced this pull request Sep 26, 2023

Backport #53309 to 23.6: Fix adding sub-second intervals to DateTime (#…

1758fea

…54981) Co-authored-by: robot-clickhouse <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix adding sub-second intervals to DateTime#53309

Fix adding sub-second intervals to DateTime#53309
al13n321 merged 1 commit intomasterfrom
int

al13n321 commented Aug 11, 2023

Uh oh!

robot-ch-test-poll4 commented Aug 11, 2023 •

edited by robot-ch-test-poll

Loading

Uh oh!

antonio2368 Aug 11, 2023

Uh oh!

al13n321 Aug 15, 2023

Uh oh!

al13n321 commented Aug 17, 2023

Uh oh!

tavplubix commented Aug 24, 2023

Uh oh!

al13n321 commented Aug 24, 2023

Uh oh!

tavplubix commented Aug 25, 2023

Uh oh!

al13n321 commented Aug 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

al13n321 commented Aug 11, 2023

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Uh oh!

robot-ch-test-poll4 commented Aug 11, 2023 • edited by robot-ch-test-poll Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antonio2368 Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

al13n321 Aug 15, 2023

Choose a reason for hiding this comment

Uh oh!

al13n321 commented Aug 17, 2023

Uh oh!

tavplubix commented Aug 24, 2023

Uh oh!

al13n321 commented Aug 24, 2023

Uh oh!

tavplubix commented Aug 25, 2023

Uh oh!

al13n321 commented Aug 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

robot-ch-test-poll4 commented Aug 11, 2023 •

edited by robot-ch-test-poll

Loading