Support skip_unused_shards in Analyzer by KochetovNicolai · Pull Request #53282 · ClickHouse/ClickHouse

KochetovNicolai · 2023-08-10T18:43:13Z

Changelog category (leave one):

Not for changelog (changelog entry is not required)

robot-ch-test-poll4 · 2023-08-10T18:43:46Z

This is an automated comment for commit cc3c038 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	❌ failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	❌ failure

novikd

In general LGTM

novikd · 2023-09-13T15:24:35Z

src/Planner/Planner.cpp

    }
 }

+/** Storages can rely that filters that for storage will be available for analysis before


We need to merge #53792 before.

novikd · 2023-09-13T15:59:53Z

src/Interpreters/evaluateConstantExpression.cpp

+    ColumnPtr tryCastColumn(ColumnPtr col, const DataTypePtr & from_type, const DataTypePtr & to_type)
+    {
+        auto to_type_no_lc = recursiveRemoveLowCardinality(to_type);
+        // std::cerr << ".. casting " << from_type->getName() << " -> " << to_type_no_lc->getName() << std::endl;


Suggested change

// std::cerr << ".. casting " << from_type->getName() << " -> " << to_type_no_lc->getName() << std::endl;

novikd · 2023-09-13T16:00:55Z

src/Interpreters/evaluateConstantExpression.cpp

+    // std::cerr << "--- inverted dag\n";
+    // std::cerr << inverted_dag->dumpDAG() << std::endl;


Suggested change

// std::cerr << "--- inverted dag\n";

// std::cerr << inverted_dag->dumpDAG() << std::endl;

novikd · 2023-09-13T16:01:12Z

src/Interpreters/evaluateConstantExpression.cpp

+    // for (const auto & [node, match] : matches)
+    // {
+    //     LOG_TRACE(&Poco::Logger::get("eeocc"), "Match {} {} -> {} {} (with monotonicity : {})",
+    //         static_cast<const void *>(node), node->result_name,
+    //         static_cast<const void *>(match.node), (match.node ? match.node->result_name : ""), match.monotonicity != std::nullopt);
+    // }


Suggested change

// for (const auto & [node, match] : matches)

// {

// LOG_TRACE(&Poco::Logger::get("eeocc"), "Match {} {} -> {} {} (with monotonicity : {})",

// static_cast<const void *>(node), node->result_name,

// static_cast<const void *>(match.node), (match.node ? match.node->result_name : ""), match.monotonicity != std::nullopt);

// }

novikd · 2023-09-13T16:01:22Z

src/Interpreters/evaluateConstantExpression.cpp

+    if (!predicates)
+        return {};
+
+    // std::cerr << "--- num predicates " << predicates->size() << std::endl;


Suggested change

// std::cerr << "--- num predicates " << predicates->size() << std::endl;

novikd · 2023-09-13T16:01:47Z

src/Storages/StorageDistributed.cpp

+    // std::cerr << query_node.dumpTree() << std::endl;
+    // std::cerr << query_info.table_expression->dumpTree() << std::endl;


Suggested change

// std::cerr << query_node.dumpTree() << std::endl;

// std::cerr << query_info.table_expression->dumpTree() << std::endl;

novikd · 2023-09-13T16:03:08Z

src/Storages/StorageDistributed.cpp

+    // GROUP BY
+    bool has_aggregates = query_info.has_aggregates;
+    if (query_info.syntax_analyzer_result)
+        has_aggregates = !query_info.syntax_analyzer_result->aggregates.empty();


strange to see in new infrastructure

novikd · 2023-09-13T16:04:33Z

src/Storages/StorageDistributed.cpp

+    // for (int i : shards)
+    //     std::cerr << ".. shard " << i << std::endl;


Suggested change

// for (int i : shards)

// std::cerr << ".. shard " << i << std::endl;

novikd · 2023-09-13T16:04:45Z

src/Storages/StorageDistributed.cpp

+    // std::cerr << "--- expr\n";
+    // std::cerr << sharding_key_dag.dumpDAG() << std::endl;


Suggested change

// std::cerr << "--- expr\n";

// std::cerr << sharding_key_dag.dumpDAG() << std::endl;

KochetovNicolai · 2023-10-31T10:32:57Z

test_s3_engine_heavy_write_check_mem is flaky and not fixed yet

test_chroot is flaky

robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 10, 2023

novikd self-assigned this Aug 10, 2023

KochetovNicolai marked this pull request as ready for review August 23, 2023 18:17

KochetovNicolai added 6 commits August 24, 2023 11:07

Update evaluateConstantExpression

c084ce5

Re-impl evaluateExpressionOverConstantCondition [part 1]

26e0ad8

Fix some skip_unused_shards tests.

fc90a1a

Re-implement getOptimizedQueryProcessingStage with analyzer.

33b8b93

Cleanup.

cb851fc

Fixing fast tests.

7136c97

KochetovNicolai force-pushed the planner-prepare-filters-for-analysis-2 branch from 6862c20 to 7136c97 Compare August 24, 2023 11:08

KochetovNicolai and others added 4 commits August 24, 2023 16:37

Fix window functions.

9737dbc

Remove comment.

506c566

Fixing clang tidy.

4e46202

Merge branch 'master' into planner-prepare-filters-for-analysis-2

903c966

novikd reviewed Sep 13, 2023

View reviewed changes

KochetovNicolai added 6 commits October 3, 2023 14:22

Remove commented code.

3b757d6

Merge branch 'master' into planner-prepare-filters-for-analysis-2

d944b59

Fixing build

c5100cd

Merge branch 'master' into planner-prepare-filters-for-analysis-2

a9a3529

Merge branch 'master' into planner-prepare-filters-for-analysis-2

554ceb4

Fixing test.

cc3c038

KochetovNicolai merged commit 0523e6c into master Oct 31, 2023

KochetovNicolai deleted the planner-prepare-filters-for-analysis-2 branch October 31, 2023 10:34

KochetovNicolai mentioned this pull request Oct 31, 2023

[Umbrella] Analyzer, Planner migration #42648

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support skip_unused_shards in Analyzer#53282

Support skip_unused_shards in Analyzer#53282
KochetovNicolai merged 16 commits intomasterfrom
planner-prepare-filters-for-analysis-2

KochetovNicolai commented Aug 10, 2023

Uh oh!

robot-ch-test-poll4 commented Aug 10, 2023 •

edited by robot-ch-test-poll

Loading

Uh oh!

novikd left a comment

Uh oh!

novikd Sep 13, 2023

Uh oh!

novikd Sep 13, 2023

Uh oh!

novikd Sep 13, 2023

Uh oh!

novikd Sep 13, 2023

Uh oh!

novikd Sep 13, 2023

Uh oh!

novikd Sep 13, 2023

Uh oh!

novikd Sep 13, 2023

Uh oh!

novikd Sep 13, 2023

Uh oh!

novikd Sep 13, 2023

Uh oh!

KochetovNicolai commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		// std::cerr << "--- inverted dag\n";
		// std::cerr << inverted_dag->dumpDAG() << std::endl;

		// std::cerr << query_node.dumpTree() << std::endl;
		// std::cerr << query_info.table_expression->dumpTree() << std::endl;

		// for (int i : shards)
		// std::cerr << ".. shard " << i << std::endl;

		// std::cerr << "--- expr\n";
		// std::cerr << sharding_key_dag.dumpDAG() << std::endl;

Conversation

KochetovNicolai commented Aug 10, 2023

Changelog category (leave one):

Uh oh!

robot-ch-test-poll4 commented Aug 10, 2023 • edited by robot-ch-test-poll Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

novikd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KochetovNicolai commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

robot-ch-test-poll4 commented Aug 10, 2023 •

edited by robot-ch-test-poll

Loading