Skip to content

Fix ZstdDeflatingWriteBuffer truncating the output sometimes#53064

Merged
alexey-milovidov merged 1 commit intomasterfrom
zstdfin
Aug 5, 2023
Merged

Fix ZstdDeflatingWriteBuffer truncating the output sometimes#53064
alexey-milovidov merged 1 commit intomasterfrom
zstdfin

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented Aug 4, 2023 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed output_format_parquet_compression_method='zstd' producing invalid Parquet files sometimes. In older versions, use setting output_format_parquet_use_custom_encoder = 0 as a workaround.

Closes #53028

ZstdDeflatingWriteBuffer::finalizeBefore() was calling ZSTD_compressStream2() once instead of in a loop.

Along the way, deduplicated nearly identical code between nextImpl() and finalizeBefore() in ZstdDeflatingWriteBuffer ZstdDeflatingAppendableWriteBuffer. Merging nearly identical ZstdDeflatingWriteBuffer and ZstdDeflatingAppendableWriteBuffer into one class is left as an exercise to the reader.

@al13n321 al13n321 requested a review from alesapin August 4, 2023 20:55
@robot-ch-test-poll robot-ch-test-poll added the pr-bugfix Pull request with bugfix, not backported by default label Aug 4, 2023
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Aug 4, 2023 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 9a128fa with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🔴 failure
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@alexey-milovidov alexey-milovidov self-assigned this Aug 4, 2023
@al13n321 al13n321 mentioned this pull request Aug 4, 2023
Closed
@alexey-milovidov alexey-milovidov merged commit 5641954 into master Aug 5, 2023
@alexey-milovidov alexey-milovidov deleted the zstdfin branch August 5, 2023 10:35
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Aug 5, 2023
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Aug 5, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Aug 5, 2023
@robot-clickhouse
Backport #53064 to 23.7: Fix ZstdDeflatingWriteBuffer truncating the …
b14b8de 
…output sometimes
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 5, 2023
alexey-milovidov added a commit that referenced this pull request Aug 5, 2023
@alexey-milovidov
Merge pull request #53079 from ClickHouse/backport/23.7/53064
a5f1a88 
Backport #53064 to 23.7: Fix ZstdDeflatingWriteBuffer truncating the output sometimes
@antonio2368
Copy link
Copy Markdown
Member

antonio2368 commented Aug 7, 2023

I'm afraid this breaks Keeper and writing to compressed log files

@antonio2368
Copy link
Copy Markdown
Member

antonio2368 commented Aug 7, 2023

@al13n321 I'm going to revert src/IO/ZstdDeflatingAppendableWriteBuffer.cpp files.
It should be only used in Keeper and it's really brittle implementation you proved yourself now because it's not easy to make appendable ZSTD write buffer work.

@tavplubix
Copy link
Copy Markdown
Member

tavplubix commented Aug 7, 2023 •
edited
Loading

Yes, it breaks Keeper and Stress tests: #53090 (comment)
I think it's okay to revert it from master now (to fix Stress tests) and freeze 23.7 until this PR is resubmitted or reverted from 23.7 as well

@tavplubix tavplubix mentioned this pull request Aug 7, 2023
Merged
antonio2368 added a commit that referenced this pull request Aug 7, 2023
@antonio2368
Revert changes from #53064
f5597b1
@antonio2368 antonio2368 mentioned this pull request Aug 7, 2023
Merged
1 task
This was referenced Aug 7, 2023
Closed
Closed
@al13n321 al13n321 mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

@alesapin alesapin Awaiting requested review from alesapin

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

query zstd parquet file error

6 participants

@al13n321 @robot-ch-test-poll @antonio2368 @tavplubix @alexey-milovidov @robot-ch-test-poll4