More precise Integer type inference, and fix #51236 by Chen768959 · Pull Request #53003 · ClickHouse/ClickHouse

Chen768959 · 2023-08-03T15:01:32Z

Changelog category (leave one):

Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

More precise Integer type inference, fix #51236

Documentation entry for user-facing changes

FieldToDataType<on_error>::operator() (const Array & x) and FieldToDataType<on_error>::operator() (const Map & map) will be able to recognize whether an UInt64 is unsigned, signed, or both, which means that an Int will have multiple possible types. This will make the getLeastSupertype function more accurate.
Example :
select [-4741124612489978151, -3236599669630092879, 5607475129431807682]
'-4741124612489978151' is Int64, '-3236599669630092879' is Int64, '5607475129431807682' is UInt64 or Int64.
So, their least supertype is Int64

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

robot-ch-test-poll4 · 2023-08-03T17:22:17Z

This is an automated comment for commit 5c2fd38 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟢 success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🟢 success
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🟢 success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

fix style.

…s enabled.

if UInt64(possible: Int64), UInt64(possible: Int64) = UInt64, UInt64 if Int64(possible: UInt32), Int64(possible: UInt32) = Int64, Int64

…if it is causing the zk validation failure issue.

…peIds method.

…the feature of automatically recognizing UInt64 as Int64.

Chen768959 · 2023-08-11T12:55:28Z

@Avogar I have completed all the modifications, and I believe this pull request is now ready for review. I would greatly appreciate it if you could take a look when you have some free time.

Avogar · 2023-08-11T12:57:12Z

Sure, I will look at it today

src/DataTypes/DataTypesNumber.h

src/DataTypes/getLeastSupertype.h

src/DataTypes/getLeastSupertype.cpp

Chen768959 · 2023-08-11T16:10:21Z

Thank you for the review and suggestions! I will make the necessary changes promptly.

…ating modifications to DataType.

Avogar · 2023-09-06T12:27:05Z

Sorry for long review, I was on vacation.
I see you changed the approach, so we don't change getLeastSupertype anymore. That's a really good Idea, I like it. Let me check the details

Avogar · 2023-09-06T12:28:28Z

src/DataTypes/FieldToDataType.cpp

    DataTypes element_types;
    element_types.reserve(x.size());

+    auto checkIfConversionSigned = [&](bool& has_signed_int, bool& has_uint64, bool& uint64_could_opposite,


I see we have 2 identical lambdas here and during Map processing. Let's move this code to a separate function in anonimous namespace in this cpp file.

And also the logic is the same here and later during Map processing. Maybe we can extract all this logic to a separate function?
Like

void convertUInt64ToInt64IfPossible(DataTypes & data_types);

So the code here will look like this:

... for (const Field & elem : x) element_types.emplace_back(applyVisitor(*this, elem)); convertUInt64ToInt64IfPossible(element_types); ...

It will be much better for future readers

OK, I'll handle it.

Chen768959 · 2023-09-07T17:01:25Z

Sorry for long review, I was on vacation.

No worries, I hope you had a great vacation!

…e to separate functions

Avogar

Looks good, thanks for the contribution!

Avogar · 2023-09-12T18:15:09Z

I just realized that this approach with changes only in FieldToDataType is actually not general, because it won't work with nested types and some functions like map/tuple:

:) select [[-4741124612489978151, 1, -3236599669630092879], [2, 5607475129431807682]]

Received exception:
Code: 386. DB::Exception: There is no supertype for types UInt64, Int64 because some of them are signed integers and some are unsigned integers, but there is no signed integer type, that can exactly represent all required unsigned integer values: While processing [[-4741124612489978151, 1, -3236599669630092879], [2, 5607475129431807682]]. (NO_COMMON_TYPE)

:) select map(-4741124612489978151, 1, -3236599669630092879, 2, 5607475129431807682, 3)

Received exception:
Code: 386. DB::Exception: There is no supertype for types UInt64, Int64 because some of them are signed integers and some are unsigned integers, but there is no signed integer type, that can exactly represent all required unsigned integer values: While processing map(-4741124612489978151, 1, -3236599669630092879, 2, 5607475129431807682, 3). (NO_COMMON_TYPE)

I think we can get back to the approach with changes in getLeastSuperType and separate constructor for DataTypeNumber (yes, I didn't like it, but as I remember there were problems with separate type because of typeid_cast, so I think it's ok).

Avogar · 2023-09-12T18:16:10Z

No worries, I will do such changes by myself, so, no need to do anything, I just wanted you to know.

More precise Integer type inference

e797d87

alexey-milovidov added the can be tested Allows running workflows for external contributors label Aug 3, 2023

robot-ch-test-poll4 added the pr-improvement Pull request with some product improvements label Aug 3, 2023

Chen768959 added 6 commits August 4, 2023 09:26

add test.

4464653

fix style.

add switch break

57d69a1

Add the optimize_type_ids parameter to control whether optimization i…

41e8345

…s enabled.

fix optimizeTypeIds, Some scenarios do not require optimization:

ad49798

if UInt64(possible: Int64), UInt64(possible: Int64) = UInt64, UInt64 if Int64(possible: UInt32), Int64(possible: UInt32) = Int64, Int64

modify comments

75a8512

temporarily disable the new Integer type inference feature to verify …

1540c02

…if it is causing the zk validation failure issue.

Avogar self-assigned this Aug 7, 2023

getPossiblePtr no longer has a default value, optimize the optimizeTy…

12d262e

…peIds method.

Chen768959 force-pushed the fix-51236 branch 2 times, most recently from ca71c39 to 12d262e Compare August 9, 2023 15:00

Chen768959 and others added 4 commits August 9, 2023 23:03

Optimize the code and streamline the functionality by retaining only …

efb041c

…the feature of automatically recognizing UInt64 as Int64.

Temporarily modify ErrorCodes to avoid conflicts.

da2a041

Merge branch 'master' into fix-51236

43d47aa

Merge branch 'master' into fix-51236

5719505

Avogar reviewed Aug 11, 2023

View reviewed changes

src/DataTypes/DataTypesNumber.h Outdated Show resolved Hide resolved

Avogar reviewed Aug 11, 2023

View reviewed changes

src/DataTypes/getLeastSupertype.h Outdated Show resolved Hide resolved

Avogar reviewed Aug 11, 2023

View reviewed changes

src/DataTypes/getLeastSupertype.cpp Outdated Show resolved Hide resolved

Avogar reviewed Aug 11, 2023

View reviewed changes

src/DataTypes/getLeastSupertype.cpp Outdated Show resolved Hide resolved

Chen768959 force-pushed the fix-51236 branch 3 times, most recently from 6cd6c23 to 5719505 Compare August 12, 2023 17:15

Addressed review feedback

74485f3

Chen768959 force-pushed the fix-51236 branch from 6e13bf2 to 74485f3 Compare August 15, 2023 13:18

Chen768959 force-pushed the fix-51236 branch 2 times, most recently from 22fe673 to 74485f3 Compare August 15, 2023 18:35

Chen768959 and others added 2 commits August 16, 2023 02:38

Perform optimization of LeastSupertype within FieldToDataType, elimin…

2683385

…ating modifications to DataType.

Merge branch 'ClickHouse:master' into fix-51236

a743a24

Chen768959 force-pushed the fix-51236 branch from 4788644 to a743a24 Compare August 16, 2023 01:23

Chen768959 and others added 2 commits August 16, 2023 09:26

fix style

3eed7dc

Merge branch 'ClickHouse:master' into fix-51236

6f9195d

Avogar reviewed Sep 6, 2023

View reviewed changes

Chen768959 and others added 2 commits September 8, 2023 14:55

Merge branch 'ClickHouse:master' into fix-51236

329c9fc

extract checkUInt64ToIn64Conversion and convertUInt64ToInt64IfPossibl…

5c2fd38

…e to separate functions

Avogar approved these changes Sep 12, 2023

View reviewed changes

Avogar merged commit 5354af0 into ClickHouse:master Sep 12, 2023

Avogar mentioned this pull request Sep 12, 2023

Better integer types inference for Int64/UInt64 fields #54553

Merged

1 task

Conversation

Chen768959 commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

Uh oh!

robot-ch-test-poll4 commented Aug 3, 2023 • edited by robot-ch-test-poll1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Chen768959 commented Aug 11, 2023

Uh oh!

Avogar commented Aug 11, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Chen768959 commented Aug 11, 2023

Uh oh!

Avogar commented Sep 6, 2023

Uh oh!

Avogar Sep 6, 2023

Choose a reason for hiding this comment

Uh oh!

Avogar Sep 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Chen768959 Sep 7, 2023

Choose a reason for hiding this comment

Uh oh!

Chen768959 commented Sep 7, 2023

Uh oh!

Avogar left a comment

Choose a reason for hiding this comment

Uh oh!

Avogar commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Avogar commented Sep 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Chen768959 commented Aug 3, 2023 •

edited

Loading

robot-ch-test-poll4 commented Aug 3, 2023 •

edited by robot-ch-test-poll1

Loading

Avogar Sep 6, 2023 •

edited

Loading

Avogar commented Sep 12, 2023 •

edited

Loading