Skip to content

Try to remove more leftovers.#52823

Merged
KochetovNicolai merged 2 commits intomasterfrom
try-fix-test_version_update_after_mutation
Jul 31, 2023
Merged

Try to remove more leftovers.#52823
KochetovNicolai merged 2 commits intomasterfrom
try-fix-test_version_update_after_mutation

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Jul 31, 2023 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Attempt to fix #44929
From https://s3.amazonaws.com/clickhouse-test-reports/0/88cd1851f0e9f6f85795371090c30d44c3762391/integration_tests__release__[4_4].html

2023.07.22 23:49:28.660209 [ 142 ] {} <Information> loadMetadata: Moved all tables from system to `.tmp_convert.system.13709156833167399561`
2023.07.22 23:49:28.660253 [ 142 ] {} <Debug> executeQuery: (internal) DROP DATABASE system (stage: Complete)
2023.07.22 23:49:28.660865 [ 142 ] {} <Error> Application: Caught exception while loading metadata: Code: 219. DB::Exception: Cannot drop: filesystem error: in remove: Directory not empty ["/var/lib/clickhouse/data/system/"]. Probably database contain some detached tables or metadata leftovers from Ordinary engine. If you want to remove all data anyway, try to attach database back and drop it again with enabled force_remove_data_recursively_on_drop setting: Exception while trying to convert database system from Ordinary to Atomic. It may be in some intermediate state. You can finish conversion manually by moving the rest tables from system to .tmp_convert.system.13709156833167399561 (using RENAME TABLE) and executing DROP DATABASE system and RENAME DATABASE .tmp_convert.system.13709156833167399561 TO system. (DATABASE_NOT_EMPTY), Stack trace (when copying this message, always include the lines below):

image

Note:

Thanks to @tavplubix

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 31, 2023
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Jul 31, 2023 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit b98d54c with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 error

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 error
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@KochetovNicolai
Revert "Merge pull request #52514 from azat/tests/fix-test_version_up…
8f5d0c0 
…date_after_mutation"

This reverts commit dd491ee, reversing
changes made to b225f9c.
@KochetovNicolai
Add flushing logs
b98d54c
@KochetovNicolai KochetovNicolai force-pushed the try-fix-test_version_update_after_mutation branch from 73704b5 to b98d54c Compare July 31, 2023 13:06
@tavplubix tavplubix self-assigned this Jul 31, 2023
@KochetovNicolai KochetovNicolai merged commit 15c77af into master Jul 31, 2023
@KochetovNicolai KochetovNicolai deleted the try-fix-test_version_update_after_mutation branch July 31, 2023 20:22
@alesapin alesapin mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tavplubix tavplubix tavplubix approved these changes

Assignees

@tavplubix tavplubix

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_version_update_after_mutation can't start server after restart

3 participants

@KochetovNicolai @robot-clickhouse @tavplubix