Skip to content

system.events and system.metrics tables add column name as an alias to event and metric#52315

Merged
kssenii merged 9 commits intoClickHouse:masterfrom
xiedeyantu:add-alias
Jul 30, 2023
Merged

system.events and system.metrics tables add column name as an alias to event and metric#52315
kssenii merged 9 commits intoClickHouse:masterfrom
xiedeyantu:add-alias

Conversation

@xiedeyantu
Copy link
Copy Markdown
Contributor

@xiedeyantu xiedeyantu commented Jul 19, 2023 •
edited by kssenii
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

system.events and system.metrics tables add column name as an alias to event and metric. close #51257

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@kssenii kssenii self-assigned this Jul 19, 2023
@kssenii kssenii added the can be tested Allows running workflows for external contributors label Jul 19, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-feature Pull request with new product feature label Jul 19, 2023
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Jul 19, 2023 •
edited
Loading

This is an automated comment for commit 08ef4d0 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

kssenii
kssenii reviewed Jul 19, 2023
View reviewed changes
@kssenii kssenii added pr-improvement Pull request with some product improvements and removed pr-feature Pull request with new product feature labels Jul 23, 2023
@kssenii
Copy link
Copy Markdown
Member

kssenii commented Jul 23, 2023

Could you please english documentation about this change?

@xiedeyantu
Copy link
Copy Markdown
Contributor Author

xiedeyantu commented Jul 23, 2023

Could you please english documentation about this change?

done

@qoega qoega mentioned this pull request Jul 24, 2023
Closed
@xiedeyantu
Copy link
Copy Markdown
Contributor Author

xiedeyantu commented Jul 26, 2023

@kssenii Hi, this pr #52540 has nothing to do with mine.

@qoega
Copy link
Copy Markdown
Member

qoega commented Jul 26, 2023

@kssenii Hi, this pr #52540 has nothing to do with mine.

We know. Just it is a fuzzer that found interesting case when running in this PR.

@kssenii
Copy link
Copy Markdown
Member

kssenii commented Jul 30, 2023

Integration tests (release) [2/4] — fail: 1

test_backup_restore_on_cluster/test_concurrency.py::test_create_or_drop_tables_during_backup[Replicated-ReplicatedMergeTree]
Issue: #45437

@kssenii kssenii merged commit 8daeeed into ClickHouse:master Jul 30, 2023
@kssenii kssenii mentioned this pull request Aug 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

system.events and system.metrics tables should have column name as an alias to event and metric

5 participants

@xiedeyantu @robot-ch-test-poll3 @kssenii @qoega @alexey-milovidov