New analyzer: add eliminate min/max/any/anyLast aggregators pass by JackyWoo · Pull Request #52230 · ClickHouse/ClickHouse

JackyWoo · 2023-07-18T03:27:21Z

Changelog category (leave one):

Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Eliminates min/max/any/anyLast aggregators of GROUP BY keys in SELECT section.

Example: SELECT max(column) FROM table GROUP BY column;
Result: SELECT column FROM table GROUP BY column;

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

robot-ch-test-poll1 · 2023-07-18T15:08:00Z

This is an automated comment for commit cadaa7b with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
A Sync	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
PR Check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	❌ failure
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	❌ failure

src/Analyzer/Passes/AggregateFunctionOfGroupByKeysPass.cpp

tests/queries/0_stateless/02496_remove_redundant_sorting_analyzer.reference

JackyWoo · 2023-08-28T06:29:14Z

Hi @novikd, please review the PR when you have a changce.

novikd

In general LGTM, but I think we should get rid of KeepEliminateFunctionVisitor.

src/Analyzer/Passes/AggregateFunctionOfGroupByKeysPass.cpp

novikd · 2024-02-22T15:55:47Z

@JackyWoo thank you for the contribution! I'm sorry that it took so long for me to review this PR. If you don't have time to finish it now, I can do it myself.

…s_of_group_by_keys

JackyWoo · 2024-02-24T15:29:15Z

Thanks I will handle it soon

novikd · 2024-02-26T10:37:52Z

I decided to reimplement this optimization a bit, I'll push my changes to this PR. It requires more attention. For example, the following query works wrong with the current implementation:

SELECT min(number) OVER (PARTITION BY number % 2)
FROM numbers(3)
GROUP BY number

devcrafter · 2024-02-27T12:59:37Z

tests/queries/0_stateless/02815_analyzer_aggregate_functions_of_group_by_keys.sql

@@ -0,0 +1,39 @@
+set allow_experimental_analyzer = 1;


The test requires comments, which will be shown in the reference file as well. So, it'd be much easier to find a query and corresponding output in reference file (and wise versa)

devcrafter · 2024-02-27T13:30:32Z

src/Analyzer/QueryTreePassManager.cpp

    manager.addPass(std::make_unique<RewriteArrayExistsToHasPass>());
    manager.addPass(std::make_unique<NormalizeCountVariantsPass>());

+    /// should before AggregateFunctionsArithmericOperationsPass


If it should be applied/not applied depends on the optimize_aggregators_of_group_by_keys setting

It is checked here

ClickHouse/src/Analyzer/Passes/AggregateFunctionOfGroupByKeysPass.cpp

Lines 35 to 36 in cadaa7b

if (!getSettings().optimize_aggregators_of_group_by_keys)

return;

…s_of_group_by_keys

JackyWoo mentioned this pull request Jul 14, 2023

Add more query tree passes to new Analyzer. #52081

Closed

6 tasks

alexey-milovidov added the can be tested Allows running workflows for external contributors label Jul 18, 2023

robot-ch-test-poll1 added the pr-performance Pull request with some performance improvements label Jul 18, 2023

JackyWoo changed the title ~~New analyzer: add aggregators_of_group_by_keys pass~~ New analyzer: add eliminate min/max/any/anyLast aggregators pass Jul 19, 2023

JackyWoo force-pushed the optimize_aggregators_of_group_by_keys branch from 87c7f8a to 4d4625f Compare July 19, 2023 06:42

novikd self-assigned this Jul 25, 2023

novikd reviewed Jul 25, 2023

View reviewed changes

JackyWoo added 7 commits July 27, 2023 19:43

Add aggregators_of_group_by_keys pass to new analyzer

1f63637

fix style

3d46725

use switch

a2001e7

fix 02496_remove_redundant_sorting_analyzer

7290b9e

fix tests

8e1dbdf

fix build error

afc6bcc

add explicit to constructor

6260887

JackyWoo force-pushed the optimize_aggregators_of_group_by_keys branch from 13f7167 to 6260887 Compare July 27, 2023 11:43

JackyWoo added 5 commits August 2, 2023 10:51

Merge branch 'master' into optimize_aggregators_of_group_by_keys

15f8bf4

use settings in visitor

f512b7a

merge 2 visitors to 1

461c2fb

fix build error

1302842

Merge branch 'master' into optimize_aggregators_of_group_by_keys

56707e3

JackyWoo requested a review from novikd August 4, 2023 13:43

Merge branch 'master' into optimize_aggregators_of_group_by_keys

d06f22a

JackyWoo force-pushed the optimize_aggregators_of_group_by_keys branch from 4c63eed to d06f22a Compare August 28, 2023 06:32

JackyWoo added 4 commits September 21, 2023 11:10

Merge branch 'master' into optimize_aggregators_of_group_by_keys

4abd0b2

merge master

337f2e2

Merge branch 'master' into optimize_aggregators_of_group_by_keys

5d2b1f5

Merge branch 'master' into optimize_aggregators_of_group_by_keys

5aaf812

novikd reviewed Feb 22, 2024

View reviewed changes

src/Analyzer/Passes/AggregateFunctionOfGroupByKeysPass.cpp Outdated Show resolved Hide resolved

novikd added the analyzer Issues and pull-requests related to new analyzer label Feb 22, 2024

novikd mentioned this pull request Feb 22, 2024

[Umbrella] Analyzer, Planner migration #42648

Closed

Merge remote-tracking branch 'origin/master' into optimize_aggregator…

600d020

…s_of_group_by_keys

novikd added 3 commits February 26, 2024 14:14

Rewrite implementation

848d400

Update comment

96dff28

Fix style

32c63cc

devcrafter reviewed Feb 27, 2024

View reviewed changes

Fix crash

6ad1062

devcrafter mentioned this pull request Feb 27, 2024

Fix: 02496_remove_redundant_sorting_analyzer #60456

Merged

novikd added 2 commits February 28, 2024 15:48

Merge remote-tracking branch 'origin/master' into optimize_aggregator…

d129bfd

…s_of_group_by_keys

Update reference file

cadaa7b

novikd merged commit 814691b into ClickHouse:master Feb 29, 2024

robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New analyzer: add eliminate min/max/any/anyLast aggregators pass#52230

New analyzer: add eliminate min/max/any/anyLast aggregators pass#52230
novikd merged 24 commits intoClickHouse:masterfrom
JackyWoo:optimize_aggregators_of_group_by_keys

JackyWoo commented Jul 18, 2023 •

edited

Loading

Uh oh!

robot-ch-test-poll1 commented Jul 18, 2023 •

edited by robot-ch-test-poll2

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JackyWoo commented Aug 28, 2023

Uh oh!

novikd left a comment

Uh oh!

Uh oh!

novikd commented Feb 22, 2024

Uh oh!

JackyWoo commented Feb 24, 2024

Uh oh!

novikd commented Feb 26, 2024

Uh oh!

devcrafter Feb 27, 2024

Uh oh!

devcrafter Feb 27, 2024

Uh oh!

JackyWoo Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	if (!getSettings().optimize_aggregators_of_group_by_keys)
	return;

Conversation

JackyWoo commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Uh oh!

robot-ch-test-poll1 commented Jul 18, 2023 • edited by robot-ch-test-poll2 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JackyWoo commented Aug 28, 2023

Uh oh!

novikd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

novikd commented Feb 22, 2024

Uh oh!

JackyWoo commented Feb 24, 2024

Uh oh!

novikd commented Feb 26, 2024

Uh oh!

devcrafter Feb 27, 2024

Choose a reason for hiding this comment

Uh oh!

devcrafter Feb 27, 2024

Choose a reason for hiding this comment

Uh oh!

JackyWoo Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JackyWoo commented Jul 18, 2023 •

edited

Loading

robot-ch-test-poll1 commented Jul 18, 2023 •

edited by robot-ch-test-poll2

Loading