Skip to content

New analyzer: add move functions out of any pass#52082

Merged
alexey-milovidov merged 13 commits intoClickHouse:masterfrom
JackyWoo:rewrite_move_functions_out_of_any
Sep 23, 2023
Merged

New analyzer: add move functions out of any pass#52082
alexey-milovidov merged 13 commits intoClickHouse:masterfrom
JackyWoo:rewrite_move_functions_out_of_any

Conversation

@JackyWoo
Copy link
Copy Markdown
Contributor

@JackyWoo JackyWoo commented Jul 13, 2023

Rewrite 'any' and 'anyLast' functions pushing them inside original function.

Example: any(f(x, y, g(z)))
Result: f(any(x), any(y), g(any(z)))

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  1. Add rewriter for new analyzer.

@qoega qoega added the can be tested Allows running workflows for external contributors label Jul 13, 2023
@robot-ch-test-poll robot-ch-test-poll added the pr-performance Pull request with some performance improvements label Jul 13, 2023
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jul 13, 2023

This is an automated comment for commit cf08067 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Mergeable CheckChecks if all other necessary checks are successful✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@JackyWoo JackyWoo force-pushed the rewrite_move_functions_out_of_any branch from 71c20bb to 3fa62ec Compare July 17, 2023 02:00
@JackyWoo JackyWoo changed the title new analyzer: move functions out of any New analyzer: add move functions out of any pass Jul 18, 2023
@JackyWoo JackyWoo force-pushed the rewrite_move_functions_out_of_any branch 2 times, most recently from 322ca45 to a974e42 Compare July 21, 2023 08:59
@novikd novikd self-assigned this Jul 25, 2023
@JackyWoo JackyWoo force-pushed the rewrite_move_functions_out_of_any branch from a974e42 to fbca348 Compare July 27, 2023 07:59
@JackyWoo JackyWoo force-pushed the rewrite_move_functions_out_of_any branch from c282696 to 98a30d6 Compare July 27, 2023 09:47
@JackyWoo JackyWoo requested a review from novikd August 4, 2023 13:42
@alexey-milovidov alexey-milovidov merged commit 06415c7 into ClickHouse:master Sep 23, 2023
@alexey-milovidov alexey-milovidov self-assigned this Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-performance Pull request with some performance improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants