Fix using locks in ProcessList#51348
Merged
vitlibar merged 3 commits intoClickHouse:masterfrom Jun 27, 2023
Merged
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
Member
|
This is an automated comment for commit 1ae51ff with description of existing statuses. It's updated for the latest CI running
|
davenger
reviewed
Jun 26, 2023
Member
davenger
left a comment
davenger
left a comment
There was a problem hiding this comment.
looks like here https://github.com/ClickHouse/ClickHouse/pull/51348/files#diff-c6034fc738bf184e41e5218132c88c572ee70ff8cad9964cd6a42643009ecf99R596-R600 context needs to be grabbed like this
ContextPtr ctx = context.lock();
if (get_settings && ctx)
{
res.query_settings = std::make_shared<Settings>(ctx->getSettings());
res.current_database = ctx->getCurrentDatabase();
}
Member
Author
done |
davenger
approved these changes
Jun 27, 2023
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Jun 28, 2023
line 2591: fix build due to ClickHouse/ClickHouse#51348
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Jun 28, 2023
line 2591: fix build due to ClickHouse/ClickHouse#51348
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Jun 28, 2023
line 2591: fix build due to ClickHouse/ClickHouse#51348
baibaichen
added a commit
to Kyligence/gluten
that referenced
this pull request
Jun 28, 2023
line 2591: fix build due to ClickHouse/ClickHouse#51348
baibaichen
added a commit
to apache/gluten
that referenced
this pull request
Jun 28, 2023
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20230628) * line 1999: fix build due to ClickHouse/ClickHouse#51455 line 2591: fix build due to ClickHouse/ClickHouse#51348 * fix build due to ClickHouse/ClickHouse#51455 --------- Co-authored-by: kyligence-git <[email protected]> Co-authored-by: Chang Chen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category:
Fixes #51150