Skip to content

Deprecate the metadata_cache feature#51303

Merged
pufit merged 12 commits intomasterfrom
deprecate-metadata-cache
Jul 28, 2023
Merged

Deprecate the metadata_cache feature#51303
pufit merged 12 commits intomasterfrom
deprecate-metadata-cache

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jun 23, 2023 •
edited
Loading

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Deprecate the metadata cache feature. It is experimental and we have never used it. The feature is dangerous: #51182. Remove the system.merge_tree_metadata_cache system table. The metadata cache is still available in this version but will be removed soon. This closes #39197.

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 23, 2023
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Jun 23, 2023 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 6573ba5 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@alexey-milovidov alexey-milovidov changed the title Remove metadata_cache from config Deprecate the metadata_cache feature Jun 23, 2023
@robot-ch-test-poll1 robot-ch-test-poll1 added pr-backward-incompatible Pull request with backwards incompatible changes and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Jun 23, 2023
@nikitamikhaylov nikitamikhaylov self-assigned this Jun 23, 2023
@pufit
Copy link
Copy Markdown
Member

pufit commented Jul 27, 2023

I've returned metadata_cache.xml into the configs, so the upgrade check should finish properly. After that, we can remove this config once and for all.

@pufit pufit merged commit 6211845 into master Jul 28, 2023
@pufit pufit deleted the deprecate-metadata-cache branch July 28, 2023 14:31
@eumenide
Copy link
Copy Markdown

eumenide commented Jan 5, 2024

@alexey-milovidov
Hi, i've douted that do merge_tree_metadata_cache settings and use_metadata_cache=1 when creating tables mean the same thing?
This feature is used to speed up loading CH, if it's removed, how can we solve the slow loading of CH?

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jan 5, 2024

The latest ClickHouse versions have parallel metadata loading to speed up the start-up time.
You can also enable asynchronous tables loading in the configuration file.

@den-crane den-crane mentioned this pull request Jan 23, 2024
Closed
@Algunenano Algunenano mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

pr-backward-incompatible Pull request with backwards incompatible changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parts metadata cache and failing mutation

6 participants

@alexey-milovidov @robot-ch-test-poll2 @pufit @eumenide @nikitamikhaylov @robot-ch-test-poll1