Skip to content

Fix metadata loading test#51297

Merged
tavplubix merged 3 commits intomasterfrom
fix-metadata-loading
Jun 23, 2023
Merged

Fix metadata loading test#51297
tavplubix merged 3 commits intomasterfrom
fix-metadata-loading

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jun 22, 2023 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

ATTACH DATABASE query became slower after introducing a parts-loading thread pool and extra logging. This closes #51185.

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 22, 2023
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Jun 22, 2023 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit f14391f with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@tavplubix
Copy link
Copy Markdown
Member

tavplubix commented Jun 23, 2023

ATTACH DATABASE query became slower after introducing a parts-loading thread pool and extra logging.

Should we make it fast again? It affects server startup time too, not only ATTACH DATABASE query.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jun 23, 2023

Should we make it fast again? It affects server startup time too, not only ATTACH DATABASE query.

I doubt it. It tests the case of multiple tables with a single part. We have optimized the case of loading tables with a large number of data parts, but the tested case became slower. More importantly, I want to make the test stable first. It was flaky even before the "pessimizations".

@tavplubix
Copy link
Copy Markdown
Member

tavplubix commented Jun 23, 2023

It tests the case of multiple tables with a single part.

Yes, because it tests metadata loading, not parts loading

We have optimized the case of loading tables with a large number of data parts

Do we have a test for that case?

It was flaky even before the "pessimizations".

It was not flaky for more than a year, see CI DB

@tavplubix
Copy link
Copy Markdown
Member

tavplubix commented Jun 23, 2023

Also, looks like the recent improvement for parts loading thread pool (#49474) introduced "heap-use-after-free" (https://github.com/ClickHouse/clickhouse-private/issues/3339)

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jun 23, 2023 •
edited
Loading

@tavplubix, revert it immediately 🤢

@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Jun 23, 2023

It seems heap-use-after-free was already fixed here #51099

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jun 23, 2023

I still want to make this change to stabilize the CI.
Functional tests are not good for performance testing...
But we can continue and pay attention to the database loading speed.

@tavplubix tavplubix self-assigned this Jun 23, 2023
@tavplubix tavplubix merged commit 8780000 into master Jun 23, 2023
@tavplubix tavplubix deleted the fix-metadata-loading branch June 23, 2023 18:45
@tavplubix tavplubix mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tavplubix tavplubix tavplubix approved these changes

Assignees

@tavplubix tavplubix

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

01193_metadata_loading is flaky (suppressed)

4 participants

@alexey-milovidov @robot-ch-test-poll2 @tavplubix @nikitamikhaylov