do not call finalize after exception#50907
Merged
CheSema merged 10 commits intoClickHouse:masterfrom Jun 23, 2023
Merged
Conversation
robot-clickhouse-ci-2
added
the
pr-not-for-changelog
Contributor
|
This is an automated comment for commit 977cd03 with description of existing statuses. It's updated for the latest CI running
|
src/Storages/StorageS3.cpp
Outdated
Member
There was a problem hiding this comment.
Ok. I was scared reading this function name, because it is the same as C's abort. Maybe cancel?
Member
Author
There was a problem hiding this comment.
void onCancel() is already in use.
Actually it is better to fix onCancel as well. But I do not have a test for it. And it is not urgent at all if compare to the changes in onException.
Member
Author
There was a problem hiding this comment.
May be release is fine here.
alexey-milovidov
approved these changes
Jun 12, 2023
CheSema
force-pushed
the
memory-leak
branch
3 times, most recently
from
caa8e3d to
c0671ca
Compare
Avogar
reviewed
Jun 13, 2023
CheSema
commented
Jun 22, 2023
Avogar
reviewed
Jun 22, 2023
Avogar
approved these changes
Jun 22, 2023
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StorageS3Sink handle exceptions in a wrong way.
test_upload_s3_fail_create_multi_part_upload -- showed that object is tried to be written at onException method after exception
test_upload_s3_fail_upload_part_when_multi_part_upload -- the same, but it ends up as a FATAL error
test_heavy_insert_select_check_memory -- just good test, let it be
Continuation for #50274
Blocked by #50395
Changelog category (leave one):