Skip to content

Fix ParallelReadBuffer seek#50820

Merged
al13n321 merged 2 commits intomasterfrom
parseek
Jun 17, 2023
Merged

Fix ParallelReadBuffer seek#50820
al13n321 merged 2 commits intomasterfrom
parseek

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented Jun 9, 2023 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

#49539 forgot to assign pos. (I probably confused it with nextImpl(), where the caller sets pos = working_buffer.begin() automatically.)

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 9, 2023
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Jun 9, 2023 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 432e571 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🔴 failure
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@al13n321
Copy link
Copy Markdown
Member Author

al13n321 commented Jun 9, 2023

Added a test.

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jun 10, 2023

Ok, but the tests are broken - need to fix them in a separate PR.

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jun 11, 2023

LGTM, but the tests have failed. We cannot merge with failed tests.

Avogar
Avogar reviewed Jun 14, 2023
View reviewed changes
tests/queries/0_stateless/02731_formats_s3.sql Outdated
Copy link
Copy Markdown
Member

@Avogar Avogar Jun 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add this file in folder data_minio and don't generate it all the time (and test will be able to run in parallel)

@al13n321 al13n321 force-pushed the parseek branch 4 times, most recently from dfc3162 to 07369ac Compare June 14, 2023 20:11
@al13n321 al13n321 merged commit 41563e4 into master Jun 17, 2023
@al13n321 al13n321 deleted the parseek branch June 17, 2023 00:50
@robot-clickhouse robot-clickhouse mentioned this pull request Jun 17, 2023
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Jun 17, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Jun 17, 2023
@robot-clickhouse
Backport #50820 to 23.5: Fix ParallelReadBuffer seek
05206a3
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 17, 2023
al13n321 pushed a commit that referenced this pull request Jun 19, 2023
@robot-clickhouse @al13n321
Backport #50820 to 23.5: Fix ParallelReadBuffer seek
6d97290
@yokofly yokofly mentioned this pull request Dec 15, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@Avogar Avogar

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@al13n321 @robot-ch-test-poll3 @alexey-milovidov @Avogar @robot-clickhouse-ci-1