Fix ubsan errors by vitlibar · Pull Request #5037 · ClickHouse/ClickHouse

vitlibar · 2019-04-17T16:26:51Z

Category (leave one):

Fixed several ubsan errors:

fix ubsan error "outside the range of representable values" in convertFieldToType.cpp;
fix ubsan error "load of misaligned address" in contrib/libmetrohash/src/platform.h;
disable ubsan error "outside the range of representable values" in bitSwapLastTwo.cpp.

…tFieldToType.cpp

…src/platform.h

…tSwapLastTwo.cpp

Vitaly Baranov added 3 commits April 17, 2019 19:10

Fix ubsan error "outside the range of representable values" in conver…

58a9105

…tFieldToType.cpp

Fix ubsan error "load of misaligned address" in contrib/libmetrohash/…

d6eb5e0

…src/platform.h

Disable ubsan error "outside the range of representable values" in bi…

7ef7a2d

…tSwapLastTwo.cpp

vitlibar requested a review from proller April 17, 2019 16:28

vitlibar assigned proller Apr 17, 2019

vitlibar removed the request for review from proller April 17, 2019 16:32

alexey-milovidov approved these changes Apr 17, 2019

View reviewed changes

alexey-milovidov self-assigned this Apr 17, 2019

vitlibar merged commit 345ae9a into ClickHouse:master Apr 17, 2019

vitlibar deleted the fix-ubsan-errors branch April 17, 2019 20:39

abyss7 added the pr-codecleanup label Apr 22, 2019

Provide feedback