Ngram classify by AntonGorokhov · Pull Request #50247 · ClickHouse/ClickHouse

AntonGorokhov · 2023-05-25T18:04:45Z

Changelog category:

New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Ngram Classification function added, so that user can SELECT smth with it

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

…Now they are useless, I throw an exception in Implementation.

… StringSlicing class. TODO: test with an SQL query and fix bugs in FunctionsNgramClassify.cpp

CLAassistant · 2023-05-25T18:04:50Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

AntonGorokhov · 2023-05-25T18:06:04Z

Hello, this is my pull request. Not everything is done yet.
I am about to finish it in couple of days

qoega

Is it still work in progress? Do you plan to add perf and stateless tests?

qoega · 2023-05-26T12:07:56Z

.zshrc

Added accidentally?

Yes, added accidentally

qoega · 2023-05-26T12:09:37Z

opt/NgramModels/Books/sherlock.txt

Also not needed if you don't use it in test? If needed in test, maybe put it in contrib and add LICENSE file?

These files are going to be used as Ngram Models inside ClickHouse. What should I do to register them?

src/Functions/FunctionsNgramClassify.cpp

src/Functions/FunctionsNgramClassify.h

AntonGorokhov · 2023-05-26T12:43:15Z

Yes, work is still in progress

robot-ch-test-poll2 · 2023-05-27T00:22:06Z

This is an automated comment for commit 4ccc0ad with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟡 pending
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Docs Check	Builds and tests the documentation	🟡 pending
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🔴 failure
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🟢 success
Mergeable Check	Checks if all other necessary checks are successful	🔴 failure
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🔴 failure
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🟢 success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

AntonGorokhov · 2023-05-29T16:48:34Z

Please explain me how to declare /opt directory with models that I added in a proper way

alexey-milovidov · 2023-05-30T07:36:03Z

opt/NgramModels/songs-ru/Oxxxymiron

@@ -0,0 +1,72 @@
+Дон ли, Волга ли течёт котомку на плечо


That's probably copyrighted, and I don't think it's fair use.

alexey-milovidov · 2023-10-09T01:45:50Z

This is not as discussed. The model file should contain (class_id, ngram, count) triples.

AntonGorokhov added 9 commits February 6, 2023 12:12

First commit. Added ".cpp" and ".h" files for Ngram Classification. w…

0a9055f

…Now they are useless, I throw an exception in Implementation.

Made String Slices fast hash implementation and model constructors

6340af2

Started implementing models push

3525bcf

Added slice scoring functions

4736cd6

Added vector and constant implementations, added Hashing function for…

2d4ac80

… StringSlicing class. TODO: test with an SQL query and fix bugs in FunctionsNgramClassify.cpp

Started implementing Classifier class

035c18d

Made good slices

852cd44

Made autoreload for Ngram Slices Storage

da7c797

Made normal Ngram Classification implementation

657411e

Now Application works for dummy throw-exception tests

8ba2fd2

qoega reviewed May 26, 2023

View reviewed changes

alexey-milovidov added the can be tested Allows running workflows for external contributors label May 27, 2023

robot-ch-test-poll2 added the pr-feature Pull request with new product feature label May 27, 2023

AntonGorokhov added 4 commits May 28, 2023 16:52

Subfinal changes

b556d5e

Everything ready, need to format code and write tests

9c8055f

Done

819ed1b

Bugfix

f77cd9d

AntonGorokhov force-pushed the NgramClassify branch 3 times, most recently from 33e5a60 to 4a66f71 Compare May 29, 2023 16:47

AntonGorokhov force-pushed the NgramClassify branch from 4a66f71 to f597a35 Compare May 29, 2023 19:11

Bugfix

f84bbfe

AntonGorokhov force-pushed the NgramClassify branch 3 times, most recently from f973a37 to 6842a88 Compare May 29, 2023 20:34

AntonGorokhov force-pushed the NgramClassify branch 2 times, most recently from 66df0a5 to ec19e7a Compare May 29, 2023 21:02

Bugfix

4ccc0ad

AntonGorokhov force-pushed the NgramClassify branch from ec19e7a to 4ccc0ad Compare May 30, 2023 06:47

alexey-milovidov reviewed May 30, 2023

View reviewed changes

rschu1ze self-assigned this Jun 27, 2023

alexey-milovidov closed this Oct 9, 2023

alexey-milovidov assigned alexey-milovidov and unassigned rschu1ze Oct 9, 2023

alexey-milovidov mentioned this pull request Dec 31, 2023

Intern Tasks 2023/2024 #58394

Closed

alexey-milovidov mentioned this pull request Oct 29, 2024

Intern Tasks 2024/2025 #71175

Closed

		@@ -0,0 +1,72 @@
		Дон ли, Волга ли течёт котомку на плечо

Conversation

AntonGorokhov commented May 25, 2023

Changelog category:

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

Uh oh!

CLAassistant commented May 25, 2023

Uh oh!

AntonGorokhov commented May 25, 2023

Uh oh!

qoega left a comment

Choose a reason for hiding this comment

Uh oh!

qoega May 26, 2023

Choose a reason for hiding this comment

Uh oh!

AntonGorokhov May 26, 2023

Choose a reason for hiding this comment

Uh oh!

qoega May 26, 2023

Choose a reason for hiding this comment

Uh oh!

AntonGorokhov May 29, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AntonGorokhov commented May 26, 2023

Uh oh!

robot-ch-test-poll2 commented May 27, 2023 • edited by robot-ch-test-poll1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AntonGorokhov commented May 29, 2023

Uh oh!

alexey-milovidov May 30, 2023

Choose a reason for hiding this comment

Uh oh!

alexey-milovidov commented Oct 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

robot-ch-test-poll2 commented May 27, 2023 •

edited by robot-ch-test-poll1

Loading