Skip to content

fix building of docs with python3#5021

Merged
blinkov merged 1 commit intoClickHouse:masterfrom
neverlee:docs/buildfix
Apr 17, 2019
Merged

fix building of docs with python3#5021
blinkov merged 1 commit intoClickHouse:masterfrom
neverlee:docs/buildfix

Conversation

@neverlee
Copy link
Copy Markdown
Contributor

@neverlee neverlee commented Apr 17, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Build/Testing/Packaging Improvement

Short description (up to few sentences):
Docs build
...

Detailed description (optional):
Support building for both of python2 and python3.
Because there is no futures:3.2.0 in packages of pip3, I use futures:3.1.1.
website.py should open file with "*b" mode for python3.
...

@blinkov blinkov merged commit f73ff1a into ClickHouse:master Apr 17, 2019
@blinkov
Copy link
Copy Markdown
Contributor

blinkov commented Apr 17, 2019

@neverlee it works ok on python2 even with requirements-py3.txt, so I'll just remove old one and rename new one.

@neverlee
Copy link
Copy Markdown
Contributor Author

neverlee commented Apr 17, 2019

Yes, requirements-py3.txt (futures:3.1.1) can work for both python2 and python3.

@neverlee neverlee deleted the docs/buildfix branch April 17, 2019 08:36
blinkov added a commit to blinkov/ClickHouse that referenced this pull request Apr 17, 2019
blinkov added a commit that referenced this pull request Apr 17, 2019
@abyss7 abyss7 added the pr-build Pull request with build/testing/packaging improvement label Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants