Skip to content

Make exception about ALTER TABLE ... DROP COLUMN|INDEX|PROJECTION more clear#50181

Merged
alesapin merged 19 commits intomasterfrom
repro_49887
Oct 25, 2023
Merged

Make exception about ALTER TABLE ... DROP COLUMN|INDEX|PROJECTION more clear#50181
alesapin merged 19 commits intomasterfrom
repro_49887

Conversation

@davenger
Copy link
Copy Markdown
Member

@davenger davenger commented May 24, 2023 •
edited by KochetovNicolai
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Closes #49887

@davenger davenger self-assigned this May 24, 2023
@davenger davenger marked this pull request as draft May 24, 2023 11:06
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 24, 2023
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented May 24, 2023 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit c3c62d9 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@KochetovNicolai
Copy link
Copy Markdown
Member

KochetovNicolai commented Sep 20, 2023

I've checked latest master, 23.8-23.5 and 23.3. The test does not reproduce anymore.

@KochetovNicolai KochetovNicolai marked this pull request as ready for review September 20, 2023 17:17
@alesapin alesapin changed the title Repro for #49887 Make exception about ALTER TABLE ... DROP COLUMN|INDEX|PROJECTION more clear Oct 11, 2023
davenger
davenger commented Oct 24, 2023
View reviewed changes
tests/queries/0_stateless/02597_column_update_tricy_expression_and_replication.sql
Copy link
Copy Markdown
Member Author

@davenger davenger Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "tricy" a typo here?

Copy link
Copy Markdown
Member

@alesapin alesapin Oct 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but let it be here

@alesapin alesapin merged commit 0d68a52 into master Oct 25, 2023
@alesapin alesapin deleted the repro_49887 branch October 25, 2023 13:57
baibaichen added a commit to Kyligence/gluten that referenced this pull request Oct 26, 2023
@baibaichen
fix build due to ClickHouse/ClickHouse#50181
dcd76e8
baibaichen added a commit to Kyligence/gluten that referenced this pull request Oct 26, 2023
@baibaichen
fix build due to ClickHouse/ClickHouse#50181
2e7c88c
baibaichen added a commit to Kyligence/gluten that referenced this pull request Oct 26, 2023
@baibaichen
fix build due to ClickHouse/ClickHouse#50181
65785aa
binmahone pushed a commit to apache/gluten that referenced this pull request Oct 26, 2023
@lwz9103 @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20231026) (#3530)
d3b91cd 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20231026)

* fix build due to ClickHouse/ClickHouse#50181

* Revert  #1837 since
ClickHouse/ClickHouse#56014.

Fix build due to removing -Wno-shadow-field

* ignore test due to ClickHouse/ClickHouse#55146

* ignore test due to ClickHouse/ClickHouse#55146

---------

Co-authored-by: kyligence-git <[email protected]>
Co-authored-by: Chang Chen <[email protected]>
azat added a commit to azat/ClickHouse that referenced this pull request Feb 19, 2025
@azat
tests: fix 02597_column_* flakiness
40041a3 
- use throwIf() + KILL MUTATION over sleep()
- disable for SMT - it checks completelly different there, note that
  02597_column_update_tricky_expression_and_replication was not even
  tested due to test-in-test architecture of the test.

Refs: ClickHouse#74798 (@nickitat)
Refs: ClickHouse#74826 (reverts it back)
Refs: ClickHouse#50181
Fixes: ClickHouse#58799
@azat azat mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin approved these changes

Assignees

@davenger davenger

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NO_SUCH_PROJECTION_IN_TABLE when doing ADD, MATERIALIZE, DROP projection on ReplicatedMergeTree

4 participants

@davenger @robot-clickhouse @KochetovNicolai @alesapin