Skip to content

Analyzer: WIP on distributed queries#50097

Merged
novikd merged 17 commits intomasterfrom
analyzer-distr-query
Jun 8, 2023
Merged

Analyzer: WIP on distributed queries#50097
novikd merged 17 commits intomasterfrom
analyzer-distr-query

Conversation

@novikd
Copy link
Copy Markdown
Member

@novikd novikd commented May 22, 2023 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support cross-replication in distributed queries using the new infrastructure.

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label May 22, 2023
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented May 22, 2023 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit 92faf4a with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@novikd novikd mentioned this pull request May 22, 2023
Closed
@novikd novikd force-pushed the analyzer-distr-query branch from 2bc78b4 to ec74cbe Compare May 22, 2023 17:21
@novikd novikd mentioned this pull request May 24, 2023
Merged
@novikd novikd force-pushed the analyzer-distr-query branch from d48058d to 480db86 Compare June 1, 2023 15:22
@novikd novikd mentioned this pull request Jun 2, 2023
Merged
@novikd novikd marked this pull request as ready for review June 5, 2023 11:02
@KochetovNicolai KochetovNicolai self-assigned this Jun 5, 2023
@novikd novikd mentioned this pull request Jun 5, 2023
Closed
@novikd novikd mentioned this pull request Jun 7, 2023
Merged
KochetovNicolai
KochetovNicolai reviewed Jun 7, 2023
View reviewed changes
src/Planner/Utils.cpp

// In case of cross-replication we don't know what database is used for the table.
// Each shard will use the default database (in the case of cross-replication shards may have different defaults).
auto result_ast = query_node_typed.toAST({ .qualify_indentifiers_with_database = false });
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need an additional check if cross-replication is really the case for a query?

@novikd novikd merged commit fd919a2 into master Jun 8, 2023
@novikd novikd deleted the analyzer-distr-query branch June 8, 2023 09:35
devcrafter added a commit that referenced this pull request Jun 13, 2023
@devcrafter
Update after #50097
e5de6cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

@kitaisreal kitaisreal

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@novikd @robot-clickhouse @KochetovNicolai @kitaisreal