Skip to content

What happens if I remove everything in msan_suppressions?#49829

Merged
rschu1ze merged 4 commits intoClickHouse:masterfrom
rschu1ze:clean-out-msan-suppression
May 23, 2023
Merged

What happens if I remove everything in msan_suppressions?#49829
rschu1ze merged 4 commits intoClickHouse:masterfrom
rschu1ze:clean-out-msan-suppression

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

Cf. #49678 (comment)

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 12, 2023
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented May 12, 2023

This is an automated comment for commit 4d06246 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🔴 failure
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@qoega
Copy link
Copy Markdown
Member

qoega commented May 13, 2023

Nothing related fails. We have no tests that trigger this assertions?

@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented May 13, 2023

The reason nothing failed is that @azat fixed the blacklisted msan issues manually in the Clang 16 upgrade.

But msan should not have been failing in the Clang 16 upgrade when these issues were not yet fixed. Looks like -fsanitize-blacklist broke with the upgrade to Clang 16. The v16 release notes say nothing about changes in this area. Parameter "blacklist" was renamed at some point o "ignorelist" but the old name theoretically continues to work. So it is not really clear why it broke.

Anyways, the ignorelist is a weird out-of-source alternate method to suppress sanitizer failures (GCC devs agree). Guess we can do without it.

@rschu1ze rschu1ze changed the title (wip) What happens if I remove everything in msan_suppressions? What happens if I remove everything in msan_suppressions? May 13, 2023
@rschu1ze rschu1ze marked this pull request as ready for review May 13, 2023 15:48
@rschu1ze rschu1ze force-pushed the clean-out-msan-suppression branch from 1b97043 to c28bb96 Compare May 13, 2023 15:48
@azat
Copy link
Copy Markdown
Member

azat commented May 13, 2023

FWIW I've verified -fsanitize-blacklist and it works:

$ cat umr.cc
#include <stdio.h>

int main(int argc, char** argv) {
  int* a = new int[10];
  a[5] = 0;
  if (a[argc])
    printf("xx\n");
  return 0;
}

$ cat blacklist.txt
# Maybe comments breaks something?
fun:main

# Maybe comments breaks something?

$ clang++-16 -fsanitize=memory -fno-omit-frame-pointer -g -O2 umr.cc -o umr && ./umr
==25090==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x5555555fd336 in main /tmp/test-msan/umr.cc:6:7
    #1 0x7ffff7a3984f  (/usr/lib/libc.so.6+0x2384f) (BuildId: 2f005a79cd1a8e385972f5a102f16adba414d75e)
    #2 0x7ffff7a39909 in __libc_start_main (/usr/lib/libc.so.6+0x23909) (BuildId: 2f005a79cd1a8e385972f5a102f16adba414d75e)
    #3 0x555555573294 in _start (/tmp/test-msan/umr+0x1f294)

SUMMARY: MemorySanitizer: use-of-uninitialized-value /tmp/test-msan/umr.cc:6:7 in main
Exiting

$ clang++-16 -fsanitize-blacklist=blacklist.txt -fsanitize=memory -fno-omit-frame-pointer -g -O2 umr.cc -o umr && ./umr

So there is something not that trivial.

@hanfei1991 hanfei1991 self-assigned this May 22, 2023
@rschu1ze
Copy link
Copy Markdown
Member Author

ClickHouse Stress Test (ubsan): #49553

@rschu1ze rschu1ze merged commit a4fe3fb into ClickHouse:master May 23, 2023
azat added a commit to azat/ClickHouse that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants