Skip to content

Allow ASOF JOIN over nullable right column#49826

Merged
vdimir merged 4 commits intomasterfrom
vdimir/asof_join_right_null
May 16, 2023
Merged

Allow ASOF JOIN over nullable right column#49826
vdimir merged 4 commits intomasterfrom
vdimir/asof_join_right_null

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented May 12, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Allow ASOF JOIN over nullable right column

This PR is also fixes 01428_nullable_asof_join for analyzer, but change is for both old and new one.

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 12, 2023
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented May 12, 2023 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 1308c29 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success

novikd
novikd approved these changes May 12, 2023
View reviewed changes
src/Interpreters/HashJoin.cpp Outdated
{
chassert(kind == JoinKind::Left || kind == JoinKind::Inner);

// Filter out rows with NULLs in asof key
Copy link
Copy Markdown
Member

@novikd novikd May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add a comment on why we should do it.

@novikd novikd self-assigned this May 12, 2023
@vdimir vdimir force-pushed the vdimir/asof_join_right_null branch from 48ac6e3 to 980b817 Compare May 15, 2023 16:57
vdimir
vdimir commented May 16, 2023
View reviewed changes
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented May 16, 2023

Mergeable Check — failed: Unit tests (asan); succeeded: ...
Unit tests (asan) — PASSED record not found. Details

Check is broken

https://play.clickhouse.com/play?user=play#U0VMRUNUIHB1bGxfcmVxdWVzdF9udW1iZXIsIGNoZWNrX3N0YXJ0X3RpbWUsIGNoZWNrX25hbWUsIGNoZWNrX3N0YXR1cywgcmVwb3J0X3VybApGUk9NIGNoZWNrcwpXSEVSRSAxCiAgICAtLUFORCBwdWxsX3JlcXVlc3RfbnVtYmVyID0gMAogICAgQU5EIGNoZWNrX3N0YXR1cyAhPSAnc3VjY2VzcycKICAgIEFORCBjaGVja19uYW1lIGxpa2UgJyVVbml0IHRlc3RzJScKICAgIEFORCBjaGVja19zdGFydF90aW1lID49IG5vdygpIC0gSU5URVJWQUwgMSBEQVkKT1JERVIgQlkgY2hlY2tfc3RhcnRfdGltZSBkZXNjLCBjaGVja19uYW1lLCB0ZXN0X25hbWUKTElNSVQgMSBCWSBjaGVja19zdGFydF90aW1l

@vdimir vdimir force-pushed the vdimir/asof_join_right_null branch from 5574612 to 1308c29 Compare May 16, 2023 14:23
@vdimir vdimir merged commit 8e5af2a into master May 16, 2023
@vdimir vdimir deleted the vdimir/asof_join_right_null branch May 16, 2023 14:24
@vdimir vdimir mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@novikd novikd novikd approved these changes

Assignees

@novikd novikd

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vdimir @robot-ch-test-poll1 @novikd