Skip to content

Fix http_skip_not_found_url with compressed files#49541

Closed
al13n321 wants to merge 3 commits intomasterfrom
skip
Closed

Fix http_skip_not_found_url with compressed files#49541
al13n321 wants to merge 3 commits intomasterfrom
skip

Conversation

@al13n321
Copy link
Copy Markdown
Member

@al13n321 al13n321 commented May 5, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix http_skip_not_found_url_for_globs not working for compressed files.

The behavior for skipping not-found URLs for globs was kind of inconsistent, in part broken by me in #47964

It skipped files by pretending that they're empty. This didn't work when the file is compressed - the decompression would error out trying to decompress an empty string.

Fixed by explicitly skipping the URL if the initial HTTP request failed, without pretending that the file is empty.

@al13n321 al13n321 requested a review from kssenii May 5, 2023 04:51
@al13n321 al13n321 changed the base branch from master to pool May 5, 2023 04:51
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-bugfix Pull request with bugfix, not backported by default label May 5, 2023
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented May 5, 2023 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit fd8042e with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 error

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch🔴 error
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🔴 failure
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🔴 failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@al13n321 al13n321 mentioned this pull request May 5, 2023
Closed
@kssenii kssenii self-assigned this May 5, 2023
kssenii
kssenii approved these changes May 5, 2023
View reviewed changes
src/IO/ReadWriteBufferFromHTTP.cpp Outdated
Comment on lines +169 to +171
auto r = getFileInfo().file_size;
if (r)
return *r;
Copy link
Copy Markdown
Member

@kssenii kssenii May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is r? May be use a bit more explanatory name?)

src/Storages/StorageURL.cpp Outdated
auto current_uri = uri_info->uri_list_to_read[current_uri_pos];

initialize(current_uri);
auto r = initialize(current_uri);
Copy link
Copy Markdown
Member

@kssenii kssenii May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for r

@al13n321 al13n321 changed the base branch from pool to master May 8, 2023 22:17
@robot-ch-test-poll robot-ch-test-poll added the submodule changed At least one submodule changed in this PR. label May 8, 2023
@robot-ch-test-poll4 robot-ch-test-poll4 removed the submodule changed At least one submodule changed in this PR. label May 11, 2023
@al13n321
Copy link
Copy Markdown
Member Author

al13n321 commented Apr 30, 2024

(It's already fixed)

@al13n321 al13n321 closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@al13n321 @robot-ch-test-poll4 @kssenii @robot-ch-test-poll